Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(README): update layout for project page #389

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Conversation

lirantal
Copy link
Member

@lirantal lirantal commented Mar 10, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Updates the README page layout

Where should the reviewer start?

Confirm links, call to actions and information is correct and fits.

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@lirantal lirantal self-assigned this Mar 10, 2019
@lirantal lirantal force-pushed the feat/readme-facelift branch from ae201e2 to c829ce7 Compare March 10, 2019 13:02
@adrukh
Copy link
Contributor

adrukh commented Mar 10, 2019

Maybe just docs: in the commit message? Doesn't seem like you'd want a new CLI release for this?

@lirantal lirantal force-pushed the feat/readme-facelift branch from c829ce7 to 6dd407b Compare March 14, 2019 14:42
@lirantal lirantal requested a review from adrukh March 14, 2019 14:42
@lirantal
Copy link
Member Author

Sorry for the late reply on this Anton, I think your comment got lost in my inbox :)
You're right we don't need a new release so I rebase the commit message.

@lirantal lirantal force-pushed the feat/readme-facelift branch from 6dd407b to 256359d Compare March 14, 2019 15:05
@lirantal lirantal force-pushed the feat/readme-facelift branch from 256359d to 1d1fd16 Compare March 14, 2019 15:14
@lili2311 lili2311 merged commit 3772223 into master Mar 14, 2019
@lili2311 lili2311 deleted the feat/readme-facelift branch March 14, 2019 18:41
@snyksec
Copy link

snyksec commented Mar 14, 2019

🎉 This PR is included in version 1.136.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants