Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Errors from snyk-iac-test should not be swallowed #4173

Merged
merged 1 commit into from
Oct 26, 2022
Merged

fix: Errors from snyk-iac-test should not be swallowed #4173

merged 1 commit into from
Oct 26, 2022

Conversation

francescomari
Copy link
Contributor

What does this PR do?

This PR fixes a bug where errors returned by snyk-iac-test are silently swallowed instead of being thrown and displayed to the user.

@francescomari francescomari requested a review from a team as a code owner October 26, 2022 15:33
@github-actions
Copy link
Contributor

Warnings
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against b02372d

moadibfr
moadibfr approved these changes Oct 26, 2022
View reviewed changes
Copy link

@moadibfr moadibfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it for cloud context specific error so LGTM

@francescomari francescomari merged commit a120139 into master Oct 26, 2022
@francescomari francescomari deleted the fix/snyk-iac-test-error-handling branch October 26, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadibfr moadibfr moadibfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francescomari @moadibfr