feat: add cloud custom rules to iac behind feature flag #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-snyk
force-pushed
the
feat/CLOUD-1176/snyk-iac-cloud-custom-rules
branch
2 times, most recently
from
da99480
to
d81b486
Compare
ofekatr
reviewed
Feb 26, 2023
| @@ -54,6 +55,10 @@ async function prepareTestConfig( | |||
| const varFile = options['var-file']; | |||
| const cloudContext = getFlag(options, 'cloud-context'); | |||
| const snykCloudEnvironment = getFlag(options, 'snyk-cloud-environment'); | |||
| const customRulesEnabled = await isFeatureFlagSupportedForOrg( | |||
There was a problem hiding this comment.
- The CLI is meant to serve solely as the UI for the IaC test, and should not be exposed to implementation details such as engine-related features gating. Could you move the move the feature flag check to
snyk/snyk-iac-testplease? - Should we also wrap this feature with the
experimentalCLI flag? Doing so provides us with an additional layer of gating to ensure the feature is not activated for pre-feature-release versions when it's not fully complete and ready for use by customers.
jason-snyk
force-pushed
the
feat/CLOUD-1176/snyk-iac-cloud-custom-rules
branch
2 times, most recently
from
23d16fe
to
39f4667
Compare
francescomari
approved these changes
Feb 28, 2023
We made some improvements to the HCL parser in snyk-iac-test v0.40.0, which will cause it reject some invalid HCL code that it used to ignore. This fixture contained an unresolved reference, so I've just added the referenced resource. [CLOUD-1176]
jason-snyk
force-pushed
the
feat/CLOUD-1176/snyk-iac-cloud-custom-rules
branch
from
fc4e3dc
to
a5ae9e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds initial support for Snyk Cloud custom rules to
snyk iac testbehind a feature flag. I also needed to fix a bug that caused non-fatal parse errors to be treated as fatal, because the most recent policy-engine emits those non-fatal errors in more situations than it used to. After this PR, we'll just debug log those errors until we can design a better way to communicate them.How should this be manually tested?
Please reach out to me and I can help you get setup to test.
What are the relevant tickets?
CLOUD-1176Screenshots
A custom rule in the results:
