Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use gw routing for code #4857

Merged
merged 6 commits into from
Oct 16, 2023
Merged

feat: use gw routing for code #4857

merged 6 commits into from
Oct 16, 2023

Conversation

Noa-Savransky
Copy link
Contributor

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@Noa-Savransky Noa-Savransky requested a review from a team as a code owner September 13, 2023 13:25
@Noa-Savransky Noa-Savransky requested a review from a team September 13, 2023 13:25
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023 •
edited
Loading

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/unit/snyk-code/snyk-code-test.spec.ts

Generated by 🚫 dangerJS against 3c8c8e3

@Noa-Savransky Noa-Savransky marked this pull request as draft September 13, 2023 13:31
pkey
pkey requested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@pkey pkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should also go to the ownership of @snyk/pulsar since we switched deeproxy ownership.

@jozsef-armin-hamos jozsef-armin-hamos marked this pull request as ready for review September 28, 2023 13:13
@jozsef-armin-hamos jozsef-armin-hamos force-pushed the feat/route-sast-to-gw branch 3 times, most recently from a4a3593 to e2c1f3e Compare October 11, 2023 08:14
@jozsef-armin-hamos jozsef-armin-hamos merged commit b7d768c into master Oct 16, 2023
7 checks passed
@jozsef-armin-hamos jozsef-armin-hamos deleted the feat/route-sast-to-gw branch October 16, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkey pkey pkey approved these changes

@PeterSchafer PeterSchafer PeterSchafer approved these changes

@strassl-snyk strassl-snyk strassl-snyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Noa-Savransky @pkey @PeterSchafer @strassl-snyk @jozsef-armin-hamos