Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated snyk-python-plugin package version #4859

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

gemaxim
Copy link
Contributor

@gemaxim gemaxim commented Sep 15, 2023

What does this PR do?

Updated the snyk-python-plugin package with a version where the pipfile parser was fixed (snyk/snyk-python-plugin#222).

What are the relevant tickets?

@gemaxim gemaxim requested a review from a team as a code owner September 15, 2023 07:34
@gemaxim gemaxim self-assigned this Sep 15, 2023
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gemaxim ,

what functionality is added and how is it covered by Acceptance Tests?

@gemaxim
Copy link
Contributor Author

gemaxim commented Sep 18, 2023

Hi @bastiandoetsch ,

You can see the breaking changes in 2.0.0 here: https://github.com/snyk/snyk-python-plugin/releases, I was only involved in a bug fix related to a support ticket, but I think @dotkas has more knowledge about the functionality in 2.0.0

@bastiandoetsch
Copy link
Contributor

@dotkas Could you please have a look at my question regarding Acceptance Tests? :)

@dotkas
Copy link
Contributor

dotkas commented Sep 18, 2023

@bastiandoetsch @gemaxim I added the breaking changes to underline that we do not support Node 12 anymore (in tests), as this was also removed from the CLI support. I felt it was good practice to increase the major version despite the PR did not introduce any breaking logic.

@dotkas
Copy link
Contributor

dotkas commented Sep 18, 2023

I suppose if

test('run `snyk test` on a python project', async () => {
const project = await createProjectFromWorkspace('pip-app');
let pythonCommand = 'python';
await runCommand(pythonCommand, ['--version']).catch(function() {
pythonCommand = 'python3';
});
console.debug('Using: ' + pythonCommand);
let pipResult = await runCommand(
pythonCommand,
[
'-m',
'pip',
'install',
'-r',
'requirements.txt',
'--break-system-packages',
],
{
shell: true,
cwd: project.path(),
},
);
if (pipResult && pipResult.code != 0) {
pipResult = await runCommand(
pythonCommand,
['-m', 'pip', 'install', '-r', 'requirements.txt'],
{
shell: true,
cwd: project.path(),
},
);
}
expect(pipResult.code).toEqual(0);
const { code } = await runSnykCLI('test -d --command=' + pythonCommand, {
cwd: project.path(),
env,
});
expect(code).toEqual(0);
still passes it should be good.

@gemaxim gemaxim force-pushed the fix/SUP-1872/pipfile-parser-fix branch 2 times, most recently from d49841e to b9a6c34 Compare September 19, 2023 06:48
@gemaxim gemaxim force-pushed the fix/SUP-1872/pipfile-parser-fix branch from b9a6c34 to 5509601 Compare September 19, 2023 06:56
@gemaxim gemaxim merged commit d37cfd6 into master Sep 19, 2023
5 checks passed
@gemaxim gemaxim deleted the fix/SUP-1872/pipfile-parser-fix branch September 19, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants