-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated snyk-python-plugin package version #4859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gemaxim ,
what functionality is added and how is it covered by Acceptance Tests?
Hi @bastiandoetsch , You can see the breaking changes in 2.0.0 here: https://github.com/snyk/snyk-python-plugin/releases, I was only involved in a bug fix related to a support ticket, but I think @dotkas has more knowledge about the functionality in 2.0.0 |
@dotkas Could you please have a look at my question regarding Acceptance Tests? :) |
@bastiandoetsch @gemaxim I added the breaking changes to underline that we do not support Node 12 anymore (in tests), as this was also removed from the CLI support. I felt it was good practice to increase the |
I suppose if cli/test/jest/acceptance/snyk-test/basic-test-all-languages.spec.ts Lines 74 to 117 in d950c5f
|
d49841e
to
b9a6c34
Compare
b9a6c34
to
5509601
Compare
What does this PR do?
Updated the snyk-python-plugin package with a version where the pipfile parser was fixed (snyk/snyk-python-plugin#222).
What are the relevant tickets?