Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct remediation (after switching to dep-graph) #499

Merged
merged 2 commits into from
May 9, 2019

Conversation

kyegupov
Copy link
Contributor

@kyegupov kyegupov commented May 9, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Fixes a remediation bug introduced by the recent switch to depGraph. (a085a05)

Injection of remediation-related information into snyk-test response should happen after conversion to the legacy response format.

Additionally: more useful error message when failing to apply a patch.

@kyegupov kyegupov force-pushed the fix/remediation branch from 9a8d36c to 25acf41 Compare May 9, 2019 14:49
@kyegupov kyegupov merged commit 8a1393a into master May 9, 2019
@kyegupov kyegupov deleted the fix/remediation branch May 9, 2019 15:21
@snyksec
Copy link

snyksec commented May 9, 2019

🎉 This PR is included in version 1.163.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants