fix: correct remediation broken after last refactoring #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyegupov
force-pushed
the
fix/remediation-after-refactoring
branch
from
f39fe7a to
42c2341
Compare
kyegupov
commented
May 10, 2019
| @@ -304,13 +311,6 @@ async function assembleLocalPayloads(root, options): Promise<Payload[]> { | |||
| body.depGraph = depGraph; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
moved the code + flipped the condition
kyegupov
commented
May 10, 2019
| @@ -0,0 +1,172 @@ | |||
| { | |||
There was a problem hiding this comment.
this is artificial, just to be compatible enough with npm-package fixture for the test to run
kyegupov
commented
May 10, 2019
| @@ -0,0 +1,89 @@ | |||
| import * as tap from 'tap'; | |||
There was a problem hiding this comment.
this file more or less copies cli-acceptance (we need a mock Registry), but only runs runTest
darscan
approved these changes
May 10, 2019
|
🎉 This PR is included in version 1.163.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes remediation which got broken in v1.161.2
Remediation relies on annotations added to the test result from the Registry. These annotations are added depending on
payload.modules, which is a piggybacking field on a request description object. In the latest refactoring, modules were erroneously (and under inverse conditions) assigned tobody.modules, which broke the refactoring workflow.Apart from the fix, now there are:
Where should the reviewer start?
The fix itself is at the bottom of src/lib/snyk-test/run-test.ts
The rest is just tests and typechecks.
How should this be manually tested?
snyk wizardnow forks on snyk-fixtures/npm-lockfiles/goof-yarn (e.g. not offering to fixbraceswhich it shouldn't).Any background context you want to provide?
The bug was introduced in 73e96aa