Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: delete expired docker promo #544

Merged
merged 1 commit into from
May 31, 2019
Merged

Chore: delete expired docker promo #544

merged 1 commit into from
May 31, 2019

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented May 29, 2019 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

This promo is expired, removing all mentions

@lili2311 lili2311 self-assigned this May 29, 2019
@lili2311 lili2311 force-pushed the chore/delete-docker-promo branch 2 times, most recently from cef6ddc to 3539980 Compare May 29, 2019 16:19
@lili2311 lili2311 changed the title Chore/delete docker promo Chore: delete expired docker promo May 29, 2019
robcresswell
robcresswell previously approved these changes May 30, 2019
View reviewed changes
@robcresswell robcresswell dismissed their stale review May 30, 2019 09:46

Too hasty :)

@lili2311 lili2311 force-pushed the chore/delete-docker-promo branch 2 times, most recently from 74a6d36 to 4ba8dc5 Compare May 30, 2019 22:11
@lili2311
Copy link
Contributor Author

Updated the PR

robcresswell
robcresswell reviewed May 31, 2019
View reviewed changes
Copy link
Contributor

@robcresswell robcresswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion; it looks like that dockerSuggestion is getting returned as an empty string early on, which isn't needed; it could be moved later.

@lili2311 lili2311 force-pushed the chore/delete-docker-promo branch from 4ba8dc5 to cbcc817 Compare May 31, 2019 10:05
@lili2311
Copy link
Contributor Author

👍 Good point, updated

@lili2311 lili2311 force-pushed the chore/delete-docker-promo branch from cbcc817 to d82df40 Compare May 31, 2019 10:15
@lili2311 lili2311 merged commit 464b784 into master May 31, 2019
@lili2311 lili2311 deleted the chore/delete-docker-promo branch May 31, 2019 10:31
@snyksec
Copy link

snyksec commented Jun 2, 2019

🎉 This PR is included in version 1.171.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Sep 12, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jul 27, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robcresswell robcresswell robcresswell approved these changes

Assignees

@lili2311 lili2311

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lili2311 @snyksec @robcresswell