Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select Gradle confugiration via name/attributes #553

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

kyegupov
Copy link
Contributor

@kyegupov kyegupov commented Jun 4, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Gradle plugin now supports selecting configurations via regexes/attributes (especially useful for Android builds).

Drive-by: simplify error analytics.

@kyegupov kyegupov requested a review from lili2311 June 4, 2019 10:50
@kyegupov kyegupov self-assigned this Jun 4, 2019
@kyegupov kyegupov force-pushed the feat/gradle-confugration-selection branch from c22ef70 to 6420f49 Compare June 4, 2019 15:20
@lili2311
Copy link
Contributor

lili2311 commented Jun 4, 2019

Please update the the cli --help file for gradle to add the new cli option? later we can link to live docs

@kyegupov kyegupov force-pushed the feat/gradle-confugration-selection branch 2 times, most recently from f907679 to cbc8f3b Compare June 5, 2019 09:39
@kyegupov
Copy link
Contributor Author

kyegupov commented Jun 5, 2019

@lili2311 help added. Now, the interesting question: do we rely anywhere on analytics error-message? The message is duplicated in the error field, so we can retain only that, but do we have any dashdoards etc that rely on error-message specifically?

@kyegupov kyegupov force-pushed the feat/gradle-confugration-selection branch from cbc8f3b to 41d9d56 Compare June 5, 2019 09:57
@kyegupov kyegupov changed the title [WIP] feat: select Gradle confugiration via name/attributes feat: select Gradle confugiration via name/attributes Jun 5, 2019
@kyegupov kyegupov merged commit d17c8ba into master Jun 5, 2019
@kyegupov kyegupov deleted the feat/gradle-confugration-selection branch June 5, 2019 10:13
@snyksec
Copy link

snyksec commented Jun 5, 2019

🎉 This PR is included in version 1.172.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants