Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: policy library logging messages to stdout instead of stderr #5583

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

oana-andrisoaei-snyk
Copy link
Contributor

@oana-andrisoaei-snyk oana-andrisoaei-snyk commented Nov 18, 2024

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

This pull request updates the policy library to 4.1.4 to fix an issue introduced in snyk-policy version 3.0. In that version the debug library began logging messages to stdout instead of stderr, causing JSON parsing to break.

The branch was created based on the test/capture-valid-esoj-output-with-policy branch, which includes an acceptance test to check if the CLI returns a well-structured json.

What are the relevant tickets?

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Warnings
⚠️ There are multiple commits on your branch, please squash them locally before merging!

Generated by 🚫 dangerJS against 0bc0aed

@oana-andrisoaei-snyk oana-andrisoaei-snyk changed the title Fix - policy library logging messages to stdout instead of stderr fix: policy library logging messages to stdout instead of stderr Nov 19, 2024
@oana-andrisoaei-snyk oana-andrisoaei-snyk marked this pull request as ready for review November 19, 2024 15:15
@oana-andrisoaei-snyk oana-andrisoaei-snyk requested a review from a team as a code owner November 19, 2024 15:15
@oana-andrisoaei-snyk oana-andrisoaei-snyk merged commit 296b51a into main Nov 19, 2024
7 checks passed
@oana-andrisoaei-snyk oana-andrisoaei-snyk deleted the fix/policy-library-output branch November 19, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants