Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow go modules monitor #576

Merged
merged 3 commits into from
Jun 14, 2019
Merged

feat: allow go modules monitor #576

merged 3 commits into from
Jun 14, 2019

Conversation

miiila
Copy link
Contributor

@miiila miiila commented Jun 12, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Allow snyk monitor for go modules. Prereq for this one is https://github.com/snyk/registry/pull/8428.

@miiila miiila requested a review from kyegupov June 12, 2019 15:49
@miiila miiila self-assigned this Jun 12, 2019
@kyegupov
Copy link
Contributor

We would probably need to update the plugin as well

@miiila miiila force-pushed the feat/go-modules-support branch from 606d016 to 5cc1ded Compare June 13, 2019 15:33
@miiila miiila changed the title inline go modules package manager naming with backed feat: allow go modules monitor Jun 13, 2019
@miiila miiila force-pushed the feat/go-modules-support branch from 5cc1ded to 1f0308c Compare June 13, 2019 15:46
Copy link
Contributor

@kyegupov kyegupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL needs fixing


const req = server.popRequest();
t.equal(req.method, 'PUT', 'makes PUT request');
t.match(req.url, '/monitor/gomod', 'puts at correct url');
Copy link
Contributor

@kyegupov kyegupov Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also gomodules here

@miiila miiila force-pushed the feat/go-modules-support branch from 1f0308c to aee5b5b Compare June 13, 2019 18:20
@miiila miiila closed this Jun 14, 2019
@miiila miiila reopened this Jun 14, 2019
@miiila miiila force-pushed the feat/go-modules-support branch from 8a79dcd to f3fee7b Compare June 14, 2019 09:24
@miiila miiila merged commit 3b6d18c into master Jun 14, 2019
@miiila miiila deleted the feat/go-modules-support branch June 14, 2019 11:26
@snyksec
Copy link

snyksec commented Jun 14, 2019

🎉 This PR is included in version 1.179.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants