feat: experimental command line flag to print the dependency tree #577
+57
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrukh
approved these changes
Jun 12, 2019
src/lib/snyk-test/run-test.ts
Outdated
| @@ -255,6 +266,9 @@ async function assembleLocalPayloads(root, options): Promise<Payload[]> { | |||
|
|
|||
| for (const depRoot of deps.depRoots) { | |||
| const pkg = depRoot.depTree; | |||
| if (options['print-dependencies']) { | |||
There was a problem hiding this comment.
Can I ask for print-deps instead? And have it appear in our help text? 🙏
There was a problem hiding this comment.
Ok, changed it to be supported in both test and monitor.
I'd rather not make it a stable feature, so marked as "experimental" in help.
Probably it should be a separate command.
kyegupov
force-pushed
the
feat/print-dep-tree-experimental
branch
2 times, most recently
from
961c358 to
a0fc845
Compare
kyegupov
force-pushed
the
feat/print-dep-tree-experimental
branch
from
a0fc845 to
c431bc4
Compare
|
@kyegupov If it's not a big issue, I'd vote for a separate command as well. I believe that sorting out all the things like |
|
@kyegupov you handle |
miiila
approved these changes
Jun 13, 2019
|
🎉 This PR is included in version 1.178.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Experimental undocumented flag
--print-dependenciesforsnyk test, useful for debugging.