Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for builds on node v6 and v7 #59

Closed
wants to merge 1 commit into from
Closed

Adding support for builds on node v6 and v7 #59

wants to merge 1 commit into from

Conversation

lirantal
Copy link
Member

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by @remy (Snyk internal team)

What does this PR do?

Adds Node v6 and v7 to the build matrix (we might want to add v7 to the allowed_failures matrix if the build constantly fails there, need to test after travis runs)

Where should the reviewer start?

Review travis build log

How should this be manually tested?

Review travis build log

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2016

CLA assistant check
All committers have signed the CLA.

@adrukh
Copy link
Contributor

adrukh commented Nov 20, 2016

Thanks @lirantal!

We're sticking to nodejs6 for now, balancing the desire to support everything while keeping our build times reasonable :)

See 40a4ce9

@adrukh adrukh closed this Nov 20, 2016
joshje referenced this pull request in joshje/snyk Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants