Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add monitor errors #599

Merged
merged 2 commits into from
Jun 25, 2019
Merged

feat: add monitor errors #599

merged 2 commits into from
Jun 25, 2019

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jun 24, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Add custom Monitor & Timeout Error with error code + message

Any background context you want to provide?

Improving cli error handling + analytics
Fixing errors like this:
Server returned unexpected error for the monitor request. Status code: 502, response: undefined
=> Server returned unexpected error for the monitor request. Status code: 502

@lili2311 lili2311 self-assigned this Jun 24, 2019
@lili2311 lili2311 force-pushed the feat/monitor-errors branch from 4a2d876 to f92021a Compare June 24, 2019 21:05
@lili2311 lili2311 force-pushed the feat/monitor-errors branch from c9442fb to aaea9bf Compare June 25, 2019 08:21
@lili2311 lili2311 merged commit 349df1a into master Jun 25, 2019
@lili2311 lili2311 deleted the feat/monitor-errors branch June 25, 2019 11:01
@snyksec
Copy link

snyksec commented Jun 25, 2019

🎉 This PR is included in version 1.184.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants