Chore/move package tests #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwywoo
reviewed
Jul 3, 2019
| before('setup', (t) => { | ||
| t.plan(3); | ||
| cli.config('get', 'api').then((key) => { | ||
| oldkey = key; // just in case |
There was a problem hiding this comment.
Can this be removed if it's there 'just in case' and verify if the old api key is required?
There was a problem hiding this comment.
Not sure, I only converted to ts 🤔 Will check in another PR what happens if I drop this
lwywoo
approved these changes
Jul 3, 2019
|
🎉 This PR is included in version 1.189.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
snyk test package@versioninto their own file need to mock some things specifically here in an upcoming PR