Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert policy.js to ts #630

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Conversation

lwywoo
Copy link
Contributor

@lwywoo lwywoo commented Jul 3, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Convert policy.js and policy test to ts.

@lwywoo lwywoo self-assigned this Jul 3, 2019
@lwywoo lwywoo requested a review from lili2311 July 3, 2019 12:25
@snyksec
Copy link

snyksec commented Jul 3, 2019

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against ba56e8b

@lwywoo lwywoo force-pushed the chore/convert-policy-from-js-ts branch 2 times, most recently from 2795138 to 52b31fe Compare July 3, 2019 15:54
@lwywoo lwywoo requested a review from dkontorovskyy July 3, 2019 16:04
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor refactoring is needed

src/cli/commands/policy.ts Outdated Show resolved Hide resolved
src/lib/display-policy.ts Outdated Show resolved Hide resolved
test/policy.test.ts Outdated Show resolved Hide resolved
test/policy.test.ts Outdated Show resolved Hide resolved
test/policy.test.ts Outdated Show resolved Hide resolved
test/policy.test.ts Outdated Show resolved Hide resolved
test/policy.test.ts Outdated Show resolved Hide resolved
test/policy.test.ts Outdated Show resolved Hide resolved
test/policy-display.test.ts Outdated Show resolved Hide resolved
test/policy-display.test.ts Outdated Show resolved Hide resolved
src/lib/display-policy.ts Show resolved Hide resolved
test/policy-display.test.ts Outdated Show resolved Hide resolved
@lwywoo lwywoo force-pushed the chore/convert-policy-from-js-ts branch from 52b31fe to 3361c26 Compare July 3, 2019 17:25
test/policy.test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor refactor needed

test/policy.test.ts Outdated Show resolved Hide resolved
test/policy.test.ts Outdated Show resolved Hide resolved
test/policy.test.ts Outdated Show resolved Hide resolved
test/policy.test.ts Outdated Show resolved Hide resolved
test/policy-display.test.ts Outdated Show resolved Hide resolved
@lwywoo lwywoo force-pushed the chore/convert-policy-from-js-ts branch from 3361c26 to d9c9e6d Compare July 4, 2019 12:55
@lwywoo lwywoo force-pushed the chore/convert-policy-from-js-ts branch from d9c9e6d to 24ea661 Compare July 4, 2019 12:57
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lwywoo lwywoo merged commit 11b7268 into master Jul 22, 2019
@lwywoo lwywoo deleted the chore/convert-policy-from-js-ts branch July 22, 2019 15:20
@snyksec
Copy link

snyksec commented Jul 22, 2019

🎉 This PR is included in version 1.197.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants