feat: convert nodejs plugin response to use multi format #773
Conversation
ghost
requested review from
lili2311
force-pushed
the
feat/node-js-mutli-project-format
branch
2 times, most recently
from
1783fb2 to
01aef00
Compare
lili2311
changed the title
src/cli/commands/monitor.ts
Outdated
| @@ -190,18 +190,18 @@ async function monitor(...args0: MethodArgs): Promise<any> { | |||
| const manageUrl = url.format(endpoint); | |||
|
|
|||
| endpoint.pathname = leader + '/monitor/' + res.id; | |||
| const subProjectName = pluginApi.isMultiResult(inspectResult) | |||
| const projectName = (pluginApi.isMultiResult(inspectResult)) | |||
| ? subProjDeps.package.name | |||
There was a problem hiding this comment.
Let's consistently rename subProj as well.
| const depTree: any = getLockFileDeps ? | ||
| await lockParser.parse(root, targetFile, options) : | ||
| await modulesParser.parse(root, targetFile, options); | ||
|
|
||
| return { | ||
| plugin: { | ||
| name: 'snyk-nodejs-lockfile-parser', | ||
| runtime: process.version, |
There was a problem hiding this comment.
This may be contradicting this change: https://github.com/snyk/snyk-cli-interface/pull/21/files#diff-b2d5ac8d1346936f02713d534de45340R93
There was a problem hiding this comment.
the issue will be that different projects will be scanned soon and they will not share always the exact same version of gradle or maven or sbt for example. Or node in this example.
There was a problem hiding this comment.
But we can fix that easily I think but adding meta inside each result not on a top level response
lili2311
force-pushed
the
feat/node-js-mutli-project-format
branch
from
01aef00 to
1e8eec8
Compare
lili2311
force-pushed
the
feat/node-js-mutli-project-format
branch
from
1e8eec8 to
9dbfb79
Compare
lili2311
force-pushed
the
feat/node-js-mutli-project-format
branch
from
9dbfb79 to
fb43699
Compare
|
Manually tested, works as expected 🎉 |
| @@ -28,7 +28,7 @@ interface GoodResult { | |||
| ok: true; | |||
| data: string; | |||
| path: string; | |||
| subProjectName?: string; | |||
| projectName?: string; | |||
There was a problem hiding this comment.
I like this change of renaming this from subProjectName to projectName. We don't really have a concept of sub project, as we monitor each sub project as separate project.
|
🎉 This PR is included in version 1.232.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
Convert the nodejs plugin code to use the new multi result format in preparation for auto detections and handling of multiple file results.