-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly document behavior of --strict-out-of-sync
and avoid string typed booleans
#779
Merged
darscan
merged 3 commits into
master
from
fix/remove-stringly-typed-boolean-option-values
Sep 30, 2019
Merged
fix: correctly document behavior of --strict-out-of-sync
and avoid string typed booleans
#779
darscan
merged 3 commits into
master
from
fix/remove-stringly-typed-boolean-option-values
Sep 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrackwitz
changed the title
fix: remove stringly typed boolean option values
fix: correctly document behavior of Sep 27, 2019
--strict-out-of-sync
and avoid string typed booleans
darscan
reviewed
Sep 27, 2019
mrackwitz
force-pushed
the
fix/remove-stringly-typed-boolean-option-values
branch
from
September 27, 2019 16:17
8e193c7
to
1efdee3
Compare
lili2311
reviewed
Sep 30, 2019
darscan
approved these changes
Sep 30, 2019
lili2311
approved these changes
Sep 30, 2019
🎉 This PR is included in version 1.228.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the help text to document the default behavior of the
--strict-out-of-sync
flag and change the options type signature to eliminate the previously present string typed boolean option values"true" | "false"
.How should this be manually tested?
The current default behavior was manually verified by @darscan and me, by running
snyk test
on a project with a lockfile (npm and yarn). Also I verified that the behavior is still the same.Any background context you want to provide?
This will make it easier to get the CocoaPods plugin working. This failed because it had a stricter options definition, not including string typed booleans: