fix: use remediation to calculate fail-on arg #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gitphill
force-pushed
the
fix/fail-on-remediation-advice-only
branch
from
cb43c83 to
1164ef3
Compare
lili2311
approved these changes
Dec 10, 2019
Adjusted logic for calculating shouldFail using remediation object instead of isPatchable, isPinnable and isUpgradable
gitphill
force-pushed
the
fix/fail-on-remediation-advice-only
branch
from
1164ef3 to
cf71309
Compare
|
🎉 This PR is included in version 1.258.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use remediation object when calculating fail-on exit code.
How should this be manually tested?
snyk test --fail-on=<all|upgradable|patchable>
Any background context you want to provide?
Response to customer confusion over exit code and messages shown in CLI
What are the relevant tickets?
BST-1094