Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly parse multistage dockerfiles written in lowercase #974

Merged
merged 1 commit into from
Jan 27, 2020
Merged

fix: correctly parse multistage dockerfiles written in lowercase #974

merged 1 commit into from
Jan 27, 2020

Conversation

RotemS
Copy link
Contributor

@RotemS RotemS commented Jan 26, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Bumping snyk-docker-plugin (contains a fix for parsing dockerfiles written in lowercase)

@RotemS RotemS requested a review from a team as a code owner January 26, 2020 12:01
@ghost ghost requested review from dkontorovskyy and lili2311 January 26, 2020 12:01
dkontorovskyy
dkontorovskyy previously approved these changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@dkontorovskyy dkontorovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkontorovskyy dkontorovskyy dismissed their stale review January 26, 2020 12:07

There is newer version on snyk-docker-plugin

dkontorovskyy
dkontorovskyy reviewed Jan 26, 2020
View reviewed changes
package.json Outdated
@@ -78,7 +78,7 @@
"proxy-from-env": "^1.0.0",
"semver": "^6.0.0",
"snyk-config": "^2.2.1",
"snyk-docker-plugin": "1.33.1",
"snyk-docker-plugin": "1.37.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already 1.38.0, maybe upgrade to that version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I missed it 🙈 Changed

@RotemS RotemS force-pushed the chore/bump-docker-plugin branch from ab396d3 to 4637063 Compare January 26, 2020 12:12
@RotemS RotemS self-assigned this Jan 26, 2020
@lili2311
Copy link
Contributor

@RotemS please change the commit to feat this is a change that release new features, chore will not trigger a release. Please could you also update the commit message to explain what will be included in this new release? The commit is part of release notes, currently it doesn't explain

@RotemS
fix: correctly parse multistage dockerfiles written in lowercase
31b97e9 
Upgrading to snyk-docker-plugin 1.38.0 that includes this fix.
@RotemS RotemS force-pushed the chore/bump-docker-plugin branch from 4637063 to 31b97e9 Compare January 27, 2020 12:24
@RotemS
Copy link
Contributor Author

RotemS commented Jan 27, 2020

@RotemS please change the commit to feat this is a change that release new features, chore will not trigger a release. Please could you also update the commit message to explain what will be included in this new release? The commit is part of release notes, currently it doesn't explain

@lili2311 hope it's ok, changed to fix as I thought it was more suitable. Also updated the commit message.

@RotemS RotemS changed the title chore: bump snyk-docker-plugin fix: correctly parse multistage dockerfiles written in lowercase Jan 27, 2020
@RotemS RotemS merged commit 2e044f4 into master Jan 27, 2020
@RotemS RotemS deleted the chore/bump-docker-plugin branch January 27, 2020 16:53
@snyksec
Copy link

snyksec commented Jan 27, 2020

🎉 This PR is included in version 1.283.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jul 16, 2020
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 7, 2020
Open
This was referenced Sep 2, 2021
Open
Open
Open
@EitanGayor EitanGayor mentioned this pull request Jun 29, 2022
Open
@romathur romathur mentioned this pull request Jun 30, 2022
Open
@joshje joshje mentioned this pull request Jun 30, 2022
Open
@RyanPHigh RyanPHigh mentioned this pull request Jun 30, 2022
Open
@claireksnyk claireksnyk mentioned this pull request Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkontorovskyy dkontorovskyy dkontorovskyy left review comments

@lili2311 lili2311 lili2311 approved these changes

Assignees

@RotemS RotemS

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RotemS @lili2311 @snyksec @dkontorovskyy