fix: support specs with platform-specific transitives #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darscan
reviewed
Oct 3, 2019
| @@ -51,6 +51,7 @@ fixtureTest( | |||
| 'CocoaPods’ integration spec install_new', | |||
| 'cp-integration-install_new' | |||
| ); | |||
| fixtureTest('Parse iina’s Podfile.lock', 'iina'); | |||
There was a problem hiding this comment.
Maybe the description should mention what is actually under test a little more? Something like:
'Unused platform specific transitives are excluded'
darscan
approved these changes
Oct 3, 2019
This supports the case where the pod is not a direct dependency of any targets of the integration, which can happen for platform-specific transitives, when their platform is not used in any target. (e.g. PromiseKit/UIKit is iOS-specific and is a transitive of PromiseKit, but won't be included for a macOS-only integration.)
mrackwitz
force-pushed
the
fix/platform-specifc-transitives
branch
from
c30d33f to
ce65397
Compare
ghost
requested review from
|
🎉 This PR is included in version 2.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mrackwitz
added a commit
to snyk/snyk-cocoapods-plugin
that referenced
this pull request
Oct 4, 2019
This was referenced Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This supports the case where the pod is not a direct dependency of any targets of the integration, which can happen for platform-specific transitives, when their platform is not used in any target. (e.g. PromiseKit/UIKit is iOS-specific and is a transitive of PromiseKit, but won't be included for a macOS-only integration.)
/c @arielorn