refactor: logger and docs

snyk · Mar 19, 2024 · f378a4c · f378a4c
1 parent fce22d6
commit f378a4c
Show file tree

Hide file tree

Showing 8 changed files with 132 additions and 25 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -17,6 +17,8 @@ git --version
 go version
 ```
 
+Also make sure to install the tools required for development by running `make generate`.
+
 ## Setting up
 
 Clone this repository with git.
@@ -41,6 +43,12 @@ To run the tests run:
 make test
 ```
 
+If writing unit tests, use the mocks generated by [GoMock](https://github.com/golang/mock) by running `make generate`. 
+
+If writing `pact` or integration tests, use the test implementations in [./internal/util/testutil](./internal/util/testutil).
+
+If you've changed any of the interfaces you may need to re-run `make generate` to generate the mocks again.
+
 ## Code ownership
 
 For current ownership assignments, see: [CODEOWNERS](./.github/CODEOWNERS).

diff --git a/README.md b/README.md
@@ -1,3 +1,69 @@
 # code-client-go
 
 A library that exposes scanning capabilities for Snyk Code that can be used in the [Snyk CLI](https://github.com/snyk/cli) as well as Snyk IDE plugins using the [Snyk Language Server](https://github.com/snyk/snyk-ls).
+
+## Installation
+
+```shell script
+$ go get github.com/snyk/code-client-go
+```
+
+## Usage
+
+### HTTP Client
+
+Use the HTTP client to make HTTP requests with configured retriable codes and authorisation headers for Snyk Rest APIs.
+
+```go
+engine := workflow.NewDefaultWorkFlowEngine()
+httpClient := http.NewHTTPClient(engine, engine.GetNetworkAccess().GetHttpClient, codeInstrumentor, codeErrorReporter)
+```
+
+The HTTP client exposes a `DoCall` function.
+
+
+### Snyk Code Client
+
+Use the Snyk Code Client to make calls to the DeepCode API using the `httpClient` HTTP client created above.
+
+
+```go
+engine := workflow.NewDefaultWorkFlowEngine()
+snykCode := deepcode.NewSnykCodeClient(engine, httpClient, testutil.NewTestInstrumentor())
+```
+
+The Snyk Code Client exposes the following functions:
+- `GetFilters`
+- `CreateBundle`
+- `ExtendBundle`
+
+### Bundle Manager
+
+Use the Bundle Manager to create bundles using the `snykCode` Snyk Code Client created above and then to extend it by uploading more files to it.
+
+```go
+bundleManager := bundle.NewBundleManager(snykCode, testutil.NewTestInstrumentor(), testutil.NewTestCodeInstrumentor())
+```
+
+The Bundle Manager exposes the following functions:
+- `Create`
+- `Upload`
+
+### Code Scanner
+
+Use the Code Scanner to trigger a scan for a Snyk Code workspace using the Bundle Manager created above:
+
+```go
+codeScanner := codeclient.NewCodeScanner(
+    bundleManager,
+    testutil.NewTestInstrumentor(),
+    testutil.NewTestCodeInstrumentor(),
+    testutils.NewTestAnalytics(),
+)
+```
+
+The Code Scanner exposes a `UploadAndAnalyze` function.
+
+### Observability
+
+Under [./observability](./observability) we have defined some observability interfaces which allows consumers of the library to inject their own observability implementations as long as they follow the defined interfaces.
diff --git a/bundle/bundle.go b/bundle/bundle.go
@@ -18,14 +18,15 @@ package bundle
 
 import (
 	"context"
+	"github.com/rs/zerolog"
 
 	"github.com/rs/zerolog/log"
 
 	"github.com/snyk/code-client-go/deepcode"
 	"github.com/snyk/code-client-go/observability"
 )
 
-//go:generate mockgen -destination=mocks/deepCodeBundle.go -source=deepCodeBundle.go -package mocks
+//go:generate mockgen -destination=mocks/bundle.go -source=bundle.go -package mocks
 type Bundle interface {
 	UploadBatch(ctx context.Context, host string, batch *Batch) error
 	GetBundleHash() string
@@ -39,6 +40,7 @@ type deepCodeBundle struct {
 	SnykCode      deepcode.SnykCodeClient
 	instrumentor  observability.Instrumentor
 	errorReporter observability.ErrorReporter
+	logger        *zerolog.Logger
 	requestId     string
 	rootPath      string
 	files         map[string]deepcode.BundleFile
@@ -48,11 +50,23 @@ type deepCodeBundle struct {
 	limitToFiles  []string
 }
 
-func NewBundle(snykCode deepcode.SnykCodeClient, instrumentor observability.Instrumentor, errorReporter observability.ErrorReporter, bundleHash string, requestId string, rootPath string, files map[string]deepcode.BundleFile, limitToFiles []string, missingFiles []string) *deepCodeBundle {
+func NewBundle(
+	snykCode deepcode.SnykCodeClient,
+	instrumentor observability.Instrumentor,
+	errorReporter observability.ErrorReporter,
+	logger *zerolog.Logger,
+	bundleHash string,
+	requestId string,
+	rootPath string,
+	files map[string]deepcode.BundleFile,
+	limitToFiles []string,
+	missingFiles []string,
+) *deepCodeBundle {
 	return &deepCodeBundle{
 		SnykCode:      snykCode,
 		instrumentor:  instrumentor,
 		errorReporter: errorReporter,
+		logger:        logger,
 		bundleHash:    bundleHash,
 		requestId:     requestId,
 		rootPath:      rootPath,

diff --git a/bundle/bundle_manager.go b/bundle/bundle_manager.go
@@ -18,6 +18,8 @@ package bundle
 
 import (
 	"context"
+	"github.com/rs/zerolog"
+	"github.com/snyk/go-application-framework/pkg/workflow"
 	"os"
 	"path/filepath"
 
@@ -34,6 +36,7 @@ type bundleManager struct {
 	SnykCode             deepcode.SnykCodeClient
 	instrumentor         observability.Instrumentor
 	errorReporter        observability.ErrorReporter
+	logger               *zerolog.Logger
 	supportedExtensions  *xsync.MapOf[string, bool]
 	supportedConfigFiles *xsync.MapOf[string, bool]
 }
@@ -56,11 +59,17 @@ type BundleManager interface {
 	) (Bundle, error)
 }
 
-func NewBundleManager(SnykCode deepcode.SnykCodeClient, instrumentor observability.Instrumentor, errorReporter observability.ErrorReporter) *bundleManager {
+func NewBundleManager(
+	engine workflow.Engine,
+	SnykCode deepcode.SnykCodeClient,
+	instrumentor observability.Instrumentor,
+	errorReporter observability.ErrorReporter,
+) *bundleManager {
 	return &bundleManager{
 		SnykCode:             SnykCode,
 		instrumentor:         instrumentor,
 		errorReporter:        errorReporter,
+		logger:               engine.GetLogger(),
 		supportedExtensions:  xsync.NewMapOf[bool](),
 		supportedConfigFiles: xsync.NewMapOf[bool](),
 	}
@@ -133,6 +142,7 @@ func (b *bundleManager) Create(ctx context.Context,
 		b.SnykCode,
 		b.instrumentor,
 		b.errorReporter,
+		b.logger,
 		bundleHash,
 		requestId,
 		rootPath,

diff --git a/bundle/bundle_manager_test.go b/bundle/bundle_manager_test.go
@@ -19,20 +19,22 @@ package bundle_test
 import (
 	"bytes"
 	"context"
-	deepcode2 "github.com/snyk/code-client-go/deepcode"
-	mocks2 "github.com/snyk/code-client-go/deepcode/mocks"
+	"github.com/rs/zerolog"
 	"os"
 	"path/filepath"
 	"strings"
 	"testing"
 
 	"github.com/golang/mock/gomock"
-	"github.com/snyk/code-client-go/observability/mocks"
+	"github.com/snyk/go-application-framework/pkg/workflow"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
 	"github.com/snyk/code-client-go/bundle"
+	deepcode2 "github.com/snyk/code-client-go/deepcode"
+	mocks2 "github.com/snyk/code-client-go/deepcode/mocks"
 	"github.com/snyk/code-client-go/internal/util"
+	"github.com/snyk/code-client-go/observability/mocks"
 )
 
 func Test_Create(t *testing.T) {
@@ -60,7 +62,7 @@ func Test_Create(t *testing.T) {
 			err := os.WriteFile(file, []byte(data), 0600)
 			require.NoError(t, err)
 
-			var bundleManager = bundle.NewBundleManager(mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
+			var bundleManager = bundle.NewBundleManager(workflow.NewDefaultWorkFlowEngine(), mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
 			bundle, err := bundleManager.Create(context.Background(),
 				"testHost",
 				"testRequestId",
@@ -93,7 +95,7 @@ func Test_Create(t *testing.T) {
 			err := os.WriteFile(file, []byte(data), 0600)
 			require.NoError(t, err)
 
-			var bundleManager = bundle.NewBundleManager(mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
+			var bundleManager = bundle.NewBundleManager(workflow.NewDefaultWorkFlowEngine(), mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
 			bundle, err := bundleManager.Create(context.Background(),
 				"testHost",
 				"testRequestId",
@@ -131,7 +133,7 @@ func Test_Create(t *testing.T) {
 			)
 			require.NoError(t, err)
 
-			var bundleManager = bundle.NewBundleManager(mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
+			var bundleManager = bundle.NewBundleManager(workflow.NewDefaultWorkFlowEngine(), mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
 			bundle, err := bundleManager.Create(context.Background(),
 				"testHost",
 				"testRequestId",
@@ -168,7 +170,7 @@ func Test_Create(t *testing.T) {
 				},
 			)
 			require.NoError(t, err)
-			var bundleManager = bundle.NewBundleManager(mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
+			var bundleManager = bundle.NewBundleManager(workflow.NewDefaultWorkFlowEngine(), mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
 			bundle, err := bundleManager.Create(context.Background(),
 				"testHost",
 				"testRequestId",
@@ -202,7 +204,7 @@ func Test_Create(t *testing.T) {
 		err := os.WriteFile(file, []byte("some content so the file won't be skipped"), 0600)
 		assert.Nil(t, err)
 
-		var bundleManager = bundle.NewBundleManager(mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
+		var bundleManager = bundle.NewBundleManager(workflow.NewDefaultWorkFlowEngine(), mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
 		bundle, err := bundleManager.Create(context.Background(),
 			"testHost",
 			"testRequestId",
@@ -251,7 +253,7 @@ func Test_Create(t *testing.T) {
 			require.NoError(t, err)
 		}
 
-		var bundleManager = bundle.NewBundleManager(mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
+		var bundleManager = bundle.NewBundleManager(workflow.NewDefaultWorkFlowEngine(), mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
 		bundle, err := bundleManager.Create(context.Background(),
 			"testHost",
 			"testRequestId",
@@ -271,6 +273,8 @@ func Test_Upload(t *testing.T) {
 		_ = os.RemoveAll(temporaryDir)
 	})
 
+	logger := zerolog.Nop()
+
 	t.Run("adds files to deepCodeBundle", func(t *testing.T) {
 		ctrl := gomock.NewController(t)
 		mockSpan := mocks.NewMockSpan(ctrl)
@@ -282,14 +286,14 @@ func Test_Upload(t *testing.T) {
 		mockInstrumentor.EXPECT().Finish(gomock.Any()).Times(2)
 		mockErrorReporter := mocks.NewMockErrorReporter(ctrl)
 
-		var bundleManager = bundle.NewBundleManager(mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
+		var bundleManager = bundle.NewBundleManager(workflow.NewDefaultWorkFlowEngine(), mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
 		documentURI, bundleFile := createTempFileInDir(t, "bundleDoc.java", 10, temporaryDir)
 		bundleFileMap := map[string]deepcode2.BundleFile{}
 		bundleFileMap[documentURI] = bundleFile
 
 		_, err := bundleManager.Upload(context.Background(),
 			"testHost",
-			bundle.NewBundle(mockSnykCodeClient, mockInstrumentor, mockErrorReporter, "bundleHash", "testRequestId", "", bundleFileMap, []string{}, []string{documentURI}),
+			bundle.NewBundle(mockSnykCodeClient, mockInstrumentor, mockErrorReporter, &logger, "bundleHash", "testRequestId", "", bundleFileMap, []string{}, []string{documentURI}),
 			bundleFileMap)
 		assert.NoError(t, err)
 	})
@@ -305,7 +309,7 @@ func Test_Upload(t *testing.T) {
 		mockInstrumentor.EXPECT().StartSpan(gomock.Any(), gomock.Any()).Return(mockSpan).Times(2)
 		mockInstrumentor.EXPECT().Finish(gomock.Any()).Times(2)
 		mockErrorReporter := mocks.NewMockErrorReporter(ctrl)
-		var bundleManager = bundle.NewBundleManager(mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
+		var bundleManager = bundle.NewBundleManager(workflow.NewDefaultWorkFlowEngine(), mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
 
 		bundleFileMap := map[string]deepcode2.BundleFile{}
 		var missingFiles []string
@@ -327,7 +331,7 @@ func Test_Upload(t *testing.T) {
 
 		_, err := bundleManager.Upload(context.Background(),
 			"testHost",
-			bundle.NewBundle(mockSnykCodeClient, mockInstrumentor, mockErrorReporter, "bundleHash", "testRequestId", "", bundleFileMap, []string{}, missingFiles),
+			bundle.NewBundle(mockSnykCodeClient, mockInstrumentor, mockErrorReporter, &logger, "bundleHash", "testRequestId", "", bundleFileMap, []string{}, missingFiles),
 			bundleFileMap)
 		assert.Nil(t, err)
 	})
@@ -349,7 +353,7 @@ func Test_IsSupported_Extensions(t *testing.T) {
 	}, nil)
 	mockInstrumentor := mocks.NewMockInstrumentor(ctrl)
 	mockErrorReporter := mocks.NewMockErrorReporter(ctrl)
-	bundler := bundle.NewBundleManager(mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
+	bundler := bundle.NewBundleManager(workflow.NewDefaultWorkFlowEngine(), mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
 
 	t.Run("should return true for supported languages", func(t *testing.T) {
 		supported, _ := bundler.IsSupported(context.Background(), "testHost", "C:\\some\\path\\Test.java")
@@ -388,7 +392,7 @@ func Test_IsSupported_ConfigFiles(t *testing.T) {
 	}, nil)
 	mockInstrumentor := mocks.NewMockInstrumentor(ctrl)
 	mockErrorReporter := mocks.NewMockErrorReporter(ctrl)
-	bundler := bundle.NewBundleManager(mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
+	bundler := bundle.NewBundleManager(workflow.NewDefaultWorkFlowEngine(), mockSnykCodeClient, mockInstrumentor, mockErrorReporter)
 	dir, _ := os.Getwd()
 
 	t.Run("should return true for supported config files", func(t *testing.T) {

diff --git a/bundle/bundle_test.go b/bundle/bundle_test.go
@@ -18,6 +18,7 @@ package bundle_test
 
 import (
 	"context"
+	"github.com/rs/zerolog"
 	"github.com/snyk/code-client-go/deepcode"
 	mocks2 "github.com/snyk/code-client-go/deepcode/mocks"
 	"testing"
@@ -37,6 +38,8 @@ var bundleWithMultipleFiles = bundle.NewBatch(map[string]deepcode.BundleFile{
 })
 
 func Test_UploadBatch(t *testing.T) {
+	testLogger := zerolog.Nop()
+
 	t.Run("when no documents - creates nothing", func(t *testing.T) {
 		ctrl := gomock.NewController(t)
 		mockSnykCodeClient := mocks2.NewMockSnykCodeClient(ctrl)
@@ -47,7 +50,7 @@ func Test_UploadBatch(t *testing.T) {
 		mockInstrumentor.EXPECT().StartSpan(gomock.Any(), gomock.Any()).Return(mockSpan).AnyTimes()
 		mockInstrumentor.EXPECT().Finish(gomock.Any()).AnyTimes()
 		mockErrorReporter := mocks.NewMockErrorReporter(ctrl)
-		b := bundle.NewBundle(mockSnykCodeClient, mockInstrumentor, mockErrorReporter, "testBundleHash", "testRequestId", "", map[string]deepcode.BundleFile{}, []string{}, []string{})
+		b := bundle.NewBundle(mockSnykCodeClient, mockInstrumentor, mockErrorReporter, &testLogger, "testBundleHash", "testRequestId", "", map[string]deepcode.BundleFile{}, []string{}, []string{})
 
 		emptyBundle := &bundle.Batch{}
 		err := b.UploadBatch(context.Background(), "testHost", emptyBundle)
@@ -67,7 +70,7 @@ func Test_UploadBatch(t *testing.T) {
 		mockInstrumentor.EXPECT().StartSpan(gomock.Any(), gomock.Any()).Return(mockSpan).AnyTimes()
 		mockInstrumentor.EXPECT().Finish(gomock.Any()).AnyTimes()
 		mockErrorReporter := mocks.NewMockErrorReporter(ctrl)
-		b := bundle.NewBundle(mockSnykCodeClient, mockInstrumentor, mockErrorReporter, "testBundleHash", "testRequestId", "", map[string]deepcode.BundleFile{}, []string{}, []string{})
+		b := bundle.NewBundle(mockSnykCodeClient, mockInstrumentor, mockErrorReporter, &testLogger, "testBundleHash", "testRequestId", "", map[string]deepcode.BundleFile{}, []string{}, []string{})
 
 		err := b.UploadBatch(context.Background(), "testHost", bundleWithFiles)
 		assert.NoError(t, err)
@@ -90,7 +93,7 @@ func Test_UploadBatch(t *testing.T) {
 		mockInstrumentor.EXPECT().StartSpan(gomock.Any(), gomock.Any()).Return(mockSpan).AnyTimes()
 		mockInstrumentor.EXPECT().Finish(gomock.Any()).AnyTimes()
 		mockErrorReporter := mocks.NewMockErrorReporter(ctrl)
-		b := bundle.NewBundle(mockSnykCodeClient, mockInstrumentor, mockErrorReporter, "testBundleHash", "testRequestId", "", map[string]deepcode.BundleFile{}, []string{}, []string{})
+		b := bundle.NewBundle(mockSnykCodeClient, mockInstrumentor, mockErrorReporter, &testLogger, "testBundleHash", "testRequestId", "", map[string]deepcode.BundleFile{}, []string{}, []string{})
 
 		err := b.UploadBatch(context.Background(), "testHost", bundleWithFiles)
 		require.NoError(t, err)

diff --git a/http/http.go b/http/http.go
@@ -46,7 +46,6 @@ type httpClient struct {
 	clientFactory func() *http.Client
 	instrumentor  observability.Instrumentor
 	errorReporter observability.ErrorReporter
-	engine        workflow.Engine
 	logger        *zerolog.Logger
 }
 
@@ -57,7 +56,7 @@ func NewHTTPClient(
 	errorReporter observability.ErrorReporter,
 ) HTTPClient {
 	logger := engine.GetLogger()
-	return &httpClient{clientFactory, instrumentor, errorReporter, engine, logger}
+	return &httpClient{clientFactory, instrumentor, errorReporter, logger}
 }
 
 var retryErrorCodes = map[int]bool{