feat: read snyk code timeout from config [IDE-399] #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
feat/read-snyk-code-timeout-config
branch
3 times, most recently
from
cb399b5
to
2769320
Compare
teodora-sandu
force-pushed
the
feat/read-snyk-code-timeout-config
branch
from
2769320
to
b7fad4b
Compare
There was a problem hiding this comment.
Would you mind adding a default of 12h, if nothing is passed? That way, we won't have panics and a default that matches LS.
There was a problem hiding this comment.
I don't think it's possible to use this without passing in a value 🤔 ? The interface will require someone to define the SnykCodeAnalysisTimeout function and so it should be the client's responsibility to set the default. Unless you mean check if 0seconds are passed in and default to 12h?
bastiandoetsch
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
snyk-lswe have a way to override the timeout and it's set to 12h by default. This PR removes the local 2minutes timeout and the option to override the timeout and instead uses the config to decide how long to wait.The CLI will also need to configure this.
Checklist
🚨After having merged, please update the
snyk-lsand CLI go.mod to pull in latest client.