-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tfstate discovery within workspaces #1562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb48e76
to
316de88
Compare
316de88
to
ec5190f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
+ Coverage 81.41% 81.43% +0.01%
==========================================
Files 442 442
Lines 16215 16229 +14
==========================================
+ Hits 13202 13216 +14
Misses 2687 2687
Partials 326 326
|
Parse workspace name first then pass it to the SupplierConfig function, so we don't it once and do not have to store it anywhere. Also add a test case for unknown backend.
eliecharra
suggested changes
Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I miss some context so I asked a few questions.
And a testcase seems useless to me
eliecharra
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current feature that discovers state from HCL files does not support non-default workspaces. This PR intend to fix that.
fix: tfstate discovering
refactor: backend to supplier config