Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract metadata from enumeration pkg #1572

Merged
merged 9 commits into from
Aug 1, 2022
Merged

Extract metadata from enumeration pkg #1572

merged 9 commits into from
Aug 1, 2022

Commits on Jul 28, 2022

  1. Configuration menu
    Copy the full SHA
    1412896 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ece051 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f906526 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    34504d6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    60d72cd View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Configuration menu
    Copy the full SHA
    e7750bc View commit details
    Browse the repository at this point in the history
  2. fix: fix broken tests

    Those tests were broken due to removal of SetResolveReadAttributesFunc.
    Sometimes in those methods we were casting field from different types to string.
    If we loose that case it causes some issues since in the detail fetcher we only take into account
    strings attributes. To fix that I added some cast directly in the detail fetcher.
    That should not cause any issues to retrieve details if we send additional (useless) fields to the
    ReadResource call.
    eliecharra committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    6c5e678 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ab94124 View commit details
    Browse the repository at this point in the history
  4. fix: linter

    eliecharra committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    a18af39 View commit details
    Browse the repository at this point in the history