-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract metadata from enumeration pkg #1572
Merged
Merged
Commits on Jul 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1412896 - Browse repository at this point
Copy the full SHA 1412896View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ece051 - Browse repository at this point
Copy the full SHA 1ece051View commit details -
Configuration menu - View commit details
-
Copy full SHA for f906526 - Browse repository at this point
Copy the full SHA f906526View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34504d6 - Browse repository at this point
Copy the full SHA 34504d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60d72cd - Browse repository at this point
Copy the full SHA 60d72cdView commit details
Commits on Aug 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e7750bc - Browse repository at this point
Copy the full SHA e7750bcView commit details -
Those tests were broken due to removal of SetResolveReadAttributesFunc. Sometimes in those methods we were casting field from different types to string. If we loose that case it causes some issues since in the detail fetcher we only take into account strings attributes. To fix that I added some cast directly in the detail fetcher. That should not cause any issues to retrieve details if we send additional (useless) fields to the ReadResource call.
Configuration menu - View commit details
-
Copy full SHA for 6c5e678 - Browse repository at this point
Copy the full SHA 6c5e678View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab94124 - Browse repository at this point
Copy the full SHA ab94124View commit details -
Configuration menu - View commit details
-
Copy full SHA for a18af39 - Browse repository at this point
Copy the full SHA a18af39View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.