fix issue when scanning without any s3_account_public_access_block #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moadibfr
force-pushed
the
fix/account_public_access_block
branch
from
7ac4f4c to
4969995
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1591 +/- ##
=======================================
Coverage 78.63% 78.63%
=======================================
Files 219 219
Lines 6952 6952
=======================================
Hits 5467 5467
Misses 1288 1288
Partials 197 197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describing s3_account_public_access_block when you never had this resource will result in a 404 that was not handled and thus failed the scan instead of just returning no resources