Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't disable acc test KMS keys #1668

Merged
merged 1 commit into from
Jun 5, 2023

Commits on Jun 5, 2023

  1. chore: don't disable acc test KMS keys

    When applying acceptance test terraform for AWS KMS key resources, we
    often see errors of the form: `Failed to set KMS key ... status to
    false: "NotFoundException: Key '...' does not exist"`. Our current
    theory is that setting is_enabled=false (as we currently do) is causing
    terraform to have to perform 2 API operations: create the key, then
    disable it. Due to the "eventualy consistency" of this API we see this
    flaking quite often.
    
    We don't actually need to disable the keys, so let's not, in an attempt
    to improve the reliability of this test.
    craigfurman committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    7eec7e2 View commit details
    Browse the repository at this point in the history