This repository was archived by the owner on Jan 9, 2024. It is now read-only.
feat: support gradlew for gradle sub projects
#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For gradle sub projects the `gradlew` util is defined on the root folder of the project. Today we are trying to get the `gradlew` util only from the target path of the gradle project and missing it. This change takes the gradle util as a parameter from the gradle plugin, which gives the benefit of having it also deal with windows.
darmalovan
force-pushed
the
feat/take-gradle-script-from-the-gradle-plugin
branch
from
ef36183 to
1d36026
Compare
juanamari94
approved these changes
Dec 10, 2020
darmalovan
deleted the
feat/take-gradle-script-from-the-gradle-plugin
branch
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
darmalovan
pushed a commit
to snyk/snyk-gradle-plugin
that referenced
this pull request
Dec 10, 2020
We want to make sure that the right gradle util is being used within the java call graph builder to allow gradle sub projects to use the correct gradlew, which can be found in the root of the project. For more context go to snyk/java-call-graph-builder#42
3 tasks
darmalovan
pushed a commit
to snyk/cli
that referenced
this pull request
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
For gradle sub projects the
gradlewutil is defined on the root folder of the project.Today we are trying to get the
gradlewutil only from the target path of the gradle project and missing scripts that are on the root folder of the project.This change takes the gradle util as a parameter from the gradle plugin, which gives the benefit of having it also deal with windows.
More information