fix: override vulnerable axios version #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuliams
approved these changes
Aug 30, 2024
|
🎉 This PR is included in version 2.21.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Overrides vulnerable Axios version from
snyk-request-manager.Motivation for overriding
axiosinstead of using later versions of the direct dependency is a breaking change introduced insnyk-request-manager1.8.5 which enforcesapi[.env].snyk.ioURLs, potentially causing customer configurations to stop working. Any existing users that supplySNYK_APIenv vars with the old[env.][app.]snyk.io/apiformat would start seeing errors and failures.As the Axios vuln needs addressing ASAP and a complete API URL handling fix would take significant time, an override is called for.
Notes for the reviewer
Instructions on how to run this locally, background context, what to review, questions…
More information
Screenshots
Visuals that may help the reviewer