fix: add special error message app for installs in preprod envs #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aarlaud
commented
Dec 18, 2024
aarlaud
commented
|
🎉 This PR is included in version 1.17.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
soniqua
reviewed
Dec 20, 2024
| @@ -39,6 +39,12 @@ export const installAppIdOnOrgId = async (orgId: string): Promise<AppInstallResp | |||
| logger.debug({url: req.url, statusCode: response.statusCode, response: response.body}, 'Response') | |||
| return JSON.parse(response.body) | |||
| } catch (error: any) { | |||
| if (error.includes('HTTP 404: Not Found: app not found')) { | |||
| throw new Error(`Unable to find the app ID. | |||
| For pre-prod environments, set the environment variable SNYK_BROKER_APP_ID=921020b6-b167-426e-867b-3e2856a2f56e. | |||
There was a problem hiding this comment.
q: can't we be smart about this and switch to the alternative app id based on the Snyk domain?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.