Chore/types #137
Merged
Chore/types #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slightly simpler to read, with named variables as well.
ghost
requested review from
Shesekino
commented
Feb 19, 2020
| runtime, | ||
| dependencies, | ||
| dockerfileAnalysis, | ||
| manifestFiles!, // bug in typescript wrongly adds `undefined` |
There was a problem hiding this comment.
mladkau
reviewed
Feb 20, 2020
mladkau
approved these changes
Feb 20, 2020
to slightly clarify the API between this library and its users, add a bit of types where easy. many of the types I've added rely on some "any"s because I'm trying to provide some initial value to make future work easier. a single place uses the non-null assertion operator: apparently there's an open bug in typescript where Promise.all() wrongly adds " | undefined" microsoft/TypeScript#33752 we'll try to keep an eye open here to see when it can be removed.
Shesekino
force-pushed
the
chore/types
branch
from
3944c39 to
953e1d2
Compare
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
some cosmetic changes to prepare improvements in the image static scanning capabilities.
each commit has plenty of information but the gist is:
async/awaitany's, but it only surfaces theseanywithout introducing new ones.Where should the reviewer start?
each commit separately.
How should this be manually tested?
as the changes are only cosmetic, I'm hoping our automated tests suffice here.
open to suggestions on how to manually test it!
Any background context you want to provide?
https://snyk.slack.com/archives/CS76EM7UM/p1582131635005500
What are the relevant tickets?
https://snyksec.atlassian.net/browse/RUN-697