-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support disable/enable Code Quality Scan #204
Conversation
Eclipse Plugin does not support disabling Code Quality Scan which impacts our developers negatively. This feature allows them to disable/enable Code Quality Scan. |
Hi @JinwooHwang-SAS , thanks for the contribution. We are looking at it right now. |
Hi @bastiandoetsch , There was a failure of build plugin with Maven. I am sorry but could you please help me find someone who can help me with this failure? Thank you. echo "$encodedString" | base64 -d > $fileName |
Yeah, it cannot retrieve & check the signing truststore from the secrets. This is nothing you can fix - I'll have a look a soon. |
Thank you so much for your help, @bastiandoetsch . |
I'll try to create the PR under my name (keeping your commit). I suppose it has to do with permissions. |
Please rebase against main once this is merged. That should fix the issue. |
Thank you @bastiandoetsch. I just rebased it. |
@JinwooHwang-SAS , looks good, I've approved. You'll need to get your commit history gpg signed, though, before I can merge. |
Thank you very much @bastiandoetsch . Let me find out how to get the commit history gpg signed, which I've never done before. I am sorry. |
Hi @bastiandoetsch . I've got the commit history gpg signed. Please let me know if I missed anything. Thank you so much for your help. |
Hi @bastiandoetsch . Thank you so much for your help. I appreciate all your support on my first commit. |
Thanks for contributing! It will go into a release tomorrow! |
You are very welcome, @bastiandoetsch. Can't wait to see the release! |
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!