Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disable/enable Code Quality Scan #204

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

JinwooHwang-SAS
Copy link
Contributor

@JinwooHwang-SAS JinwooHwang-SAS commented Oct 1, 2024

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@JinwooHwang-SAS JinwooHwang-SAS requested a review from a team as a code owner October 1, 2024 19:58
@JinwooHwang-SAS
Copy link
Contributor Author

Eclipse Plugin does not support disabling Code Quality Scan which impacts our developers negatively. This feature allows them to disable/enable Code Quality Scan.

@bastiandoetsch
Copy link
Contributor

Hi @JinwooHwang-SAS , thanks for the contribution. We are looking at it right now.

@JinwooHwang-SAS
Copy link
Contributor Author

Hi @bastiandoetsch ,
Thank you for reviewing the commit.

There was a failure of build plugin with Maven. I am sorry but could you please help me find someone who can help me with this failure? Thank you.

echo "$encodedString" | base64 -d > $fileName
echo "$sha $fileName" > sha256.txt
sha256sum -c sha256.txt
shell: /usr/bin/bash -e {0}
env:
JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64
JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64
fileName: ./keystore.jks
encodedString:
sha:
sha256sum: sha256.txt: no properly formatted SHA256 checksum lines found
Error: Process completed with exit code 1.

@bastiandoetsch
Copy link
Contributor

Yeah, it cannot retrieve & check the signing truststore from the secrets. This is nothing you can fix - I'll have a look a soon.

@JinwooHwang-SAS
Copy link
Contributor Author

Thank you so much for your help, @bastiandoetsch .

@bastiandoetsch
Copy link
Contributor

I'll try to create the PR under my name (keeping your commit). I suppose it has to do with permissions.

@bastiandoetsch
Copy link
Contributor

Please rebase against main once this is merged. That should fix the issue.

@JinwooHwang-SAS
Copy link
Contributor Author

Thank you @bastiandoetsch. I just rebased it.

@bastiandoetsch
Copy link
Contributor

@JinwooHwang-SAS , looks good, I've approved. You'll need to get your commit history gpg signed, though, before I can merge.

@JinwooHwang-SAS
Copy link
Contributor Author

Thank you very much @bastiandoetsch . Let me find out how to get the commit history gpg signed, which I've never done before. I am sorry.

@JinwooHwang-SAS
Copy link
Contributor Author

Hi @bastiandoetsch . I've got the commit history gpg signed. Please let me know if I missed anything. Thank you so much for your help.

@bastiandoetsch bastiandoetsch merged commit 260554d into snyk:main Oct 21, 2024
6 checks passed
@JinwooHwang-SAS
Copy link
Contributor Author

Hi @bastiandoetsch . Thank you so much for your help. I appreciate all your support on my first commit.

@bastiandoetsch
Copy link
Contributor

Thanks for contributing! It will go into a release tomorrow!

@JinwooHwang-SAS
Copy link
Contributor Author

You are very welcome, @bastiandoetsch. Can't wait to see the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants