Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: icon rendering [IDE-811] #238

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: icon rendering [IDE-811] #238

merged 1 commit into from
Dec 5, 2024

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Dec 5, 2024 •
edited
Loading

Description

  • render file icons correctly
  • don't use disposed icons

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

image image

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner December 5, 2024 12:26
acke
acke approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@acke acke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastiandoetsch bastiandoetsch force-pushed the fix/IDE-811_icons-too-small branch from 3d057be to 5f3c5f6 Compare December 5, 2024 12:32
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) December 5, 2024 12:33
@bastiandoetsch bastiandoetsch merged commit 232d12a into main Dec 5, 2024
7 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/IDE-811_icons-too-small branch December 5, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acke acke acke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastiandoetsch @acke