fix: make sure all images created are disposed #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/BaseTreeNode.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
plugin/src/main/java/io/snyk/eclipse/plugin/views/snyktoolview/BaseTreeNode.java
Fixed
Show fixed
Hide fixed
acke
force-pushed
the
fix/IDE-979_imagedescriptor_dispose
branch
5 times, most recently
from
b7e7ad7 to
c552267
Compare
acke
force-pushed
the
fix/IDE-979_imagedescriptor_dispose
branch
3 times, most recently
from
0036723 to
f65882e
Compare
acke
force-pushed
the
fix/IDE-979_imagedescriptor_dispose
branch
10 times, most recently
from
e8cf460 to
ced80c0
Compare
bastiandoetsch
force-pushed
the
fix/IDE-979_imagedescriptor_dispose
branch
from
6de0e94 to
04e9b03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using Eclipse ImageRegistry to cache images, and make sure they are disposed of correctly.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!