feat: use code-client-go to create and extend bundle [IDE-175] #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
4 tasks
teodora-sandu
force-pushed
the
feat/code-client-go
branch
from
af3e57b
to
58e9802
Compare
teodora-sandu
force-pushed
the
feat/code-client-go
branch
from
58e9802
to
9c8f1a2
Compare
teodora-sandu
force-pushed
the
feat/code-client-go
branch
from
9c8f1a2
to
cba44c6
Compare
teodora-sandu
force-pushed
the
feat/code-client-go
branch
from
cba44c6
to
5e5b5c6
Compare
teodora-sandu
force-pushed
the
feat/code-client-go
branch
from
18c8426
to
f2b5abb
Compare
teodora-sandu
force-pushed
the
feat/code-client-go
branch
from
3378039
to
00243cc
Compare
teodora-sandu
had a problem deploying
to
Standard
GitHub Actions
Failure
teodora-sandu
force-pushed
the
feat/code-client-go
branch
from
00243cc
to
5053291
Compare
teodora-sandu
had a problem deploying
to
Standard
GitHub Actions
Failure
teodora-sandu
force-pushed
the
feat/code-client-go
branch
from
5053291
to
7984072
Compare
cat2608
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starts using the
code-client-golibrary for uploading and analyzing Snyk Code files with ignores. Updates to the latestcode-client-goas a result and includes the bundle creation/extension of the files in the workspace.Tested in IntelliJ by running
make build-debuginsnyk-lsandmake buildin the CLI , then changing the path to the CLI in IntelliJ. I enabled thesnykCodeConsistentIgnoresfeature flag and thesnyk.preview.snyk.code.ls.enabledregistry flag, then opened IntelliJ on https://github.com/snyk/target-serviceAlso added smoke tests, which I was able to run in my IDE. See screenshot for proof of passing. The token was a service account token created for our new test org.
Checklist
🚨After having merged, please update the CLI go.mod to pull in latest language server.
Screenshots / GIFs