chore: explicitly set token authentication when using the CLI #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
force-pushed
the
chore/CLI-326_support_oauth_default
branch
from
ed8c9b3
to
872b87e
Compare
PeterSchafer
force-pushed
the
chore/CLI-326_support_oauth_default
branch
from
872b87e
to
2176270
Compare
cmars
approved these changes
May 15, 2024
|
Closing since this change will be replaced by another solution in the CLI |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CLI default authentication will be switching to OAuth, since snyk-ls uses the CLI for token based authentication, it is necessary to explicitly state the
auth-typeto be token.This can be tested with the
previewversion of the CLI, which already uses OAuth as default.The expected behaviour is that snyk-ls still uses token based authentication unless it is connecting to fedramp instances or the authentication type is changed.
Checklist
🚨After having merged, please update the CLI go.mod to pull in latest language server.
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!