Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow oauth2 authentication #544

Merged
merged 28 commits into from
Jul 9, 2024
Merged

Conversation

bastiandoetsch
Copy link
Collaborator

@bastiandoetsch bastiandoetsch commented Jun 14, 2024

Description

This PR overhauls the authentication in Language Server.

  1. By default, it registers OAuth2 as primary provider and Token (CLI) Authentication as secondary. If OAuth2 fails, it automatically falls back to token authentication.
  2. By specifying token as authentication method during initialization, or as configuration update, Token-only authentication can be forced.
  3. The whole authentication & initialization code has been moved to streamline dependencies (top->down). Authentication does not have backlinks to the snyk domain anymore.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing
  • License file updated, if new 3rd-party dependency is introduced

🚨After having merged, please update the CLI go.mod to pull in latest language server.

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch changed the title feat: enable oauth authentication by default feat: allow oauth2 authentication Jul 9, 2024
@bastiandoetsch bastiandoetsch merged commit 87d492b into main Jul 9, 2024
15 checks passed
@bastiandoetsch bastiandoetsch deleted the feat/enable-oauth2-by-default branch July 9, 2024 11:42
ShawkyZ pushed a commit that referenced this pull request Jul 10, 2024
ShawkyZ pushed a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants