fix: output with warnings and env vars #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitphill
force-pushed
the
fix/parse-warnings-and-env-var
branch
from
9df21f9 to
c352378
Compare
gitphill
force-pushed
the
fix/parse-warnings-and-env-var
branch
from
c352378 to
cdf5983
Compare
Fixing bug when mvn output contains unresolved properties, i.e.
'${my.prop}'.
gitphill
force-pushed
the
fix/parse-warnings-and-env-var
branch
from
cdf5983 to
ad05525
Compare
Jdunsby
approved these changes
Apr 5, 2023
| @@ -0,0 +1,6 @@ | |||
| const regex = /digraph([\s\S]*?)\}[\s]*?$/gm; | |||
There was a problem hiding this comment.
Nitpick: could it be cleaner to parse based on "? Something like "[^"]*" ?
alexandru-dragomir
approved these changes
Apr 5, 2023
|
🎉 This PR is included in version 2.32.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug when mvn output contains unresolved properties, i.e.
'${my.prop}'.