Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [OSM-1122] use workspaces parser #16

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

gemaxim
Copy link
Collaborator

@gemaxim gemaxim commented Jul 16, 2024

What this does

See snyk/nodejs-lockfile-parser#234.

Notes for the reviewer

Instructions on how to run this locally, background context, what to review, questions…

More information

Screenshots

Visuals that may help the reviewer

@gemaxim gemaxim self-assigned this Jul 16, 2024
package.json Outdated
@@ -42,7 +42,7 @@
"lodash.isempty": "^4.4.0",
"lodash.sortby": "^4.7.0",
"micromatch": "4.0.7",
"snyk-nodejs-lockfile-parser": "^1.56.1",
"snyk-nodejs-lockfile-parser": "file:../snyk-nodejs-lockfile-parser",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to add the actual version here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, changed it

@gemaxim gemaxim force-pushed the feat/OSM-1122/pnpm-workspace-parsing branch 2 times, most recently from a91c3fd to 23eef95 Compare July 24, 2024 01:18
@gemaxim gemaxim force-pushed the feat/OSM-1122/pnpm-workspace-parsing branch from 23eef95 to f728af9 Compare July 25, 2024 07:33
@gemaxim gemaxim marked this pull request as ready for review July 25, 2024 07:37
@gemaxim gemaxim requested a review from a team as a code owner July 25, 2024 07:37
@gemaxim gemaxim merged commit 47710cf into main Jul 25, 2024
11 checks passed
@gemaxim gemaxim deleted the feat/OSM-1122/pnpm-workspace-parsing branch July 25, 2024 07:59
@snyksec
Copy link

snyksec commented Jul 25, 2024

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants