fix: fixing bug where .deps file was placed in a subdir of the publis…

…h folder (#205)

lib/nuget-parser/cli/dotnet.ts

@@ -116,6 +116,7 @@ export async function publish(
   const tempDir = fs.mkdtempSync(
     path.join(os.tmpdir(), `snyk-nuget-plugin-publish-csharp-`),
   );
+
   // See https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/7.0/solution-level-output-no-longer-valid#recommended-action
   // about why we're not using `--output` for this.
   args.push(`--property:PublishDir=${tempDir}`);

lib/nuget-parser/index.ts

@@ -8,7 +8,11 @@ import * as dotnetCoreV2Parser from './parsers/dotnet-core-v2-parser';
 import * as dotnetFrameworkParser from './parsers/dotnet-framework-parser';
 import * as projectJsonParser from './parsers/project-json-parser';
 import * as packagesConfigParser from './parsers/packages-config-parser';
-import { FileNotProcessableError, InvalidManifestError } from '../errors';
+import {
+  CliCommandError,
+  FileNotProcessableError,
+  InvalidManifestError,
+} from '../errors';
 import {
   AssemblyVersions,
   DotnetCoreV2Results,
@@ -71,6 +75,34 @@ function getFileContents(fileContentPath: string): string {
   }
 }
 
+// `dotnet` can publish the .deps file to a variety of places inside the publish folder, depending on what you're
+// including and targeting. Instead of trying different directories, just scan them all. In most cases, the file
+// will be in the root directory. (See https://github.com/Azure/azure-functions-vs-build-sdk/issues/518)
+function findDepsFilePathInPublishDir(dir: string): string | null {
+  for (const item of fs.readdirSync(dir)) {
+    const itemPath = path.join(dir, item);
+
+    // The file is usually <project>.deps.json, but in edge cases, `dotnet` names it for you.
+    if (itemPath.endsWith('deps.json')) {
+      return itemPath;
+    }
+
+    if (!fs.statSync(itemPath).isDirectory()) {
+      continue;
+    }
+
+    // Otherwise, look in a nested dir for the same thing.
+    const foundFilePath = findDepsFilePathInPublishDir(itemPath);
+    if (!foundFilePath) {
+      continue;
+    }
+
+    return foundFilePath;
+  }
+
+  return null;
+}
+
 export async function buildDepGraphFromFiles(
   root: string | undefined,
   targetFile: string | undefined,
@@ -162,10 +194,13 @@ Will attempt to build dependency graph anyway, but the operation might fail.`);
     const publishDir = await dotnet.publish(safeRoot, decidedTargetFramework);
 
     // Then inspect the dependency graph for the runtimepackage's assembly versions.
-    const depsFilePath = path.resolve(
-      publishDir,
-      `${projectNameFromManifestFile}.deps.json`,
-    );
+    const filename = `${projectNameFromManifestFile}.deps.json`;
+    const depsFilePath = findDepsFilePathInPublishDir(publishDir);
+    if (!depsFilePath) {
+      throw new CliCommandError(
+        `unable to locate ${filename} anywhere inside ${publishDir}, file is needed for runtime resolution to occur, aborting`,
+      );
+    }
 
     const depsFile = fs.readFileSync(depsFilePath);
     const publishedProjectDeps: PublishedProjectDeps = JSON.parse(

test/fixtures/dotnetcore/dotnet_8_with_azure_functions/README.md

@@ -0,0 +1,7 @@
+# dotnet_8_functions_bin_folder
+
+Including a `<PackageReference Include="Microsoft.NET.Sdk.Functions" Version="4.1.3"/>` above version 4.x will cause
+a `dotnet publish` to add `/bin` to the publish dir, confusing this logic on where the `.deps` file, containing runtime
+pack information, is located.
+
+See [this thread for more](https://github.com/Azure/azure-functions-vs-build-sdk/issues/518).

test/fixtures/dotnetcore/dotnet_8_with_azure_functions/dotnet_8_with_azure_functions.csproj

@@ -0,0 +1,9 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <TargetFramework>net8.0</TargetFramework>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Sdk.Functions" Version="4.3.0" />
+  </ItemGroup>
+</Project>