Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read target framework from any PropertyGroup #102

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

jan-stehlik
Copy link
Contributor

@jan-stehlik jan-stehlik commented Aug 12, 2021

Parse target framework from any PropertyGroup within project file.

Introduce jest tests

Make sure to add support for node 10 as snyk CLI supports node 10+

@jan-stehlik jan-stehlik requested a review from a team as a code owner August 12, 2021 16:23
@jan-stehlik jan-stehlik force-pushed the fix/read-target-framework-from-any-property-group branch from 04d8cd7 to 783f34c Compare August 12, 2021 16:55
@JamesPatrickGill JamesPatrickGill dismissed their stale review August 12, 2021 20:40

flatmap to be removed

@jan-stehlik jan-stehlik force-pushed the fix/read-target-framework-from-any-property-group branch 3 times, most recently from 106efdf to 3f12f58 Compare August 13, 2021 10:11
@jan-stehlik jan-stehlik force-pushed the fix/read-target-framework-from-any-property-group branch from 3f12f58 to 351d39a Compare August 13, 2021 10:18
@jan-stehlik jan-stehlik force-pushed the fix/read-target-framework-from-any-property-group branch from 7d1ab0d to 936f464 Compare August 13, 2021 10:31
@jan-stehlik jan-stehlik merged commit 19f6381 into master Aug 13, 2021
@jan-stehlik jan-stehlik deleted the fix/read-target-framework-from-any-property-group branch August 13, 2021 11:32
@snyksec
Copy link

snyksec commented Aug 13, 2021

🎉 This PR is included in version 1.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants