fix: [OSM-797] Remove runtime.* natives from depGraph
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotkas
force-pushed
the
dotkas/OSM-797/remove-runtime-natives-from-depgraph
branch
from
79fb75e to
9c8a9c1
Compare
dotkas
commented
Nov 17, 2023
Comment on lines
-182
to
-191
|
|
||
| // Ignore packages with specific prefixes, which for one reason or the other are no interesting and pollutes the graph. | ||
| if ( | ||
| FILTERED_DEPENDENCY_PREFIX.some((prefix) => | ||
| nameWithVersion.startsWith(prefix), | ||
| ) | ||
| ) { | ||
| return acc; | ||
| } | ||
|
|
There was a problem hiding this comment.
Only handled top level deps.
dotkas
force-pushed
the
dotkas/OSM-797/remove-runtime-natives-from-depgraph
branch
4 times, most recently
from
77da96b to
7a1eab3
Compare
dotkas
force-pushed
the
dotkas/OSM-797/remove-runtime-natives-from-depgraph
branch
from
7a1eab3 to
3fcd498
Compare
yurinka1
approved these changes
Nov 19, 2023
dotkas
deleted the
dotkas/OSM-797/remove-runtime-natives-from-depgraph
branch
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our case, we are already creating the correct dependencies and their respective runtime version numbers based of our runtime resolution logic. So a dependency will already be
System.Net.Http@8.0.0if running on .NET 8, thus removing the need for aruntime.native.System.Net.Http@8.0.0as well. From our investigation these runtime native dependencies are causing noise for the customers and are not of interested.Changes:
v2parserruntime.*dependencies