fix: scan non publishable projects #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37IulianPopovici
force-pushed
the
fix-scan-non-publishable-project
branch
from
eba3716
to
437e26d
Compare
gemaxim
approved these changes
Sep 2, 2024
|
🎉 This issue has been resolved in version 2.7.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET projects can be configured to not be publishable (test project as for example)
Improved .NET needs those projects to be publishable in order to generate the self-contained binary that has all the required runtime dependencies
https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-publish#msbuild
This PR enhances the
dotnet publishcommand to overwrite<IsPublishable>property to be true in order to successfully scan those projects.