fix: refactor build tree algorithm #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
talik077
force-pushed
the
chore/refactor-tree-build
branch
from
3e67526
to
c2c7bcc
Compare
|
:wow: 👏 |
orsagie
reviewed
Aug 5, 2019
talik077
force-pushed
the
chore/refactor-tree-build
branch
from
c2c7bcc
to
2c271a4
Compare
|
can you also rename to commit to |
talik077
force-pushed
the
chore/refactor-tree-build
branch
2 times, most recently
from
a0b33bf
to
e325685
Compare
ghost
requested a review
from
talik077
changed the title
orsagie
reviewed
Aug 5, 2019
orsagie
reviewed
Aug 5, 2019
| let depResolvedName = ''; | ||
| let originalDepKey = ''; | ||
| function isFreqDep(packageName: string): boolean { | ||
| return packageName in freqDeps; |
There was a problem hiding this comment.
This syntax actually works?! TIL
There was a problem hiding this comment.
@orsagie this works :) but you need to be really careful :) cos in freqDeps is an object this will also return true:
'toString' in freqDeps
'__proto__' in freqDeps
'constructor' in freqDeps etc
orsagie
reviewed
Aug 5, 2019
executing snyk test took very long time due to the parsing algorithm. this pr is a poc that introduce a different approach for constructing dep tree using bfs algorithm. with this technique processing time decreased by x25
talik077
force-pushed
the
chore/refactor-tree-build
branch
from
e325685
to
850f018
Compare
orsagie
approved these changes
Aug 5, 2019
|
🎉 This PR is included in version 1.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
running
snyk testcommand in order to scan local NuGet dependencies, took approx ~2.5 minutes in the best case for a user. after digging a bit, It was easy to notice that the dep tree parsing algorithm was the root cause for this issue since it used recursive function inside a loop, which has high time complexity. this PR introduces a different approach for constructing a dep tree using the BFS algorithm. with this technique, processing time decreased by x25.How should this be manually tested?
snyk-dev test --file="some.nugetdeps.json"Any background context you want to provide?
zendesk user complain
Screenshots
Before (139120ms):
After (5478ms):