Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use dotnet-deps-parser 4.5.2 #64

Merged
merged 1 commit into from
Oct 14, 2019
Merged

feat: use dotnet-deps-parser 4.5.2 #64

merged 1 commit into from
Oct 14, 2019

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Oct 14, 2019 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Bump to use latest parser version

@lili2311 lili2311 requested a review from a team as a code owner October 14, 2019 11:35
@ghost ghost requested review from miiila and orsagie October 14, 2019 11:35
adrukh
adrukh reviewed Oct 14, 2019
View reviewed changes
Copy link
Contributor

@adrukh adrukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ‘why’ instead of ‘what’ as the commit message? :)

@lili2311
Copy link
Contributor Author

@adrukh the changes in the parser bring no useful why here, it is just to keep up to date.

@adrukh
Copy link
Contributor

adrukh commented Oct 14, 2019

keeping the parser up to date, no functional impact 👍

gitphill
gitphill approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@gitphill gitphill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not to be too picky on your commit messages, but patser should be parser :)

@lili2311
feat: keeping the parser up to date, no functional impact
eac889a 
The changes in the parser at this stage do not affect any functionality
in the plugin
@lili2311 lili2311 merged commit 0812618 into master Oct 14, 2019
@lili2311 lili2311 deleted the feat/use-parser-4.5.2 branch October 14, 2019 12:49
@snyksec
Copy link

snyksec commented Oct 14, 2019

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrukh adrukh adrukh left review comments

@gitphill gitphill gitphill approved these changes

@miiila miiila Awaiting requested review from miiila

@orsagie orsagie Awaiting requested review from orsagie

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lili2311 @adrukh @snyksec @gitphill