Add retry-all-errors curl parameter

[pera]

Lately we have seen Exited with code exit status 56 quite often during the download Snyk CLI step. The error is transient and usually goes away with one manual rerun.

This PR adds an extra option to make curl retry even on network layer errors.

Related previous PR: #63

[CLAassistant]

All committers have signed the CLA.

[j-luong]

Hi,

Transient errors should be handled by the --retry flag, unfortunately adding --retry-all-errors would be too broad, and is not recommended.

Error 56 would suggest a network error, which could be for many different reasons, it's really not possible to say without more information. I would suggest doing some investigation on your network to identify the cause, things like proxies, antivirus, firewalls, etc could all be causes.

[pera]

@j-luong the warning in the documentation is not relevant in this case as in the script curl is only used to download Snyk CLI and the checksum. Also the error happens between CircleCI and static.snyk.io, not our network.

Could you please reconsider merging this PR? This issue is unfortunately quite common.

[bastiandoetsch]

We just discussed internally, and decided that in this case, we're ok with going against the advice.

[bastiandoetsch]

But before it can be merged, the commit must be signed. So please sign the commit and force-push to this branch again. Also, please change the commit message to "chore: add retry-all-errors curl parameter" for semantic release to work properly.

[pera]

done, thanks @bastiandoetsch

[bastiandoetsch]

hey @pera , should be available in snyk-orb@1.5.1

[pera]

@bastiandoetsch sorry but this PR should be reverted ASAP:

Downloading Snyk CLI version 1.1166.0
curl: option --retry-all-errors: is unknown
curl: try 'curl --help' or 'curl --manual' for more information

This option was added in curl-7.71.0 but this orb is using Ubuntu 20.04 (cimg/base:stable-20.04) that comes with curl-7.68.0

[bastiandoetsch]

Yeah, the orb is reverted for now. We'll see if we can update the base image without consequences - I doubt it's gonna be a problem to update to 22.04.

[pera]

Thanks, this problem is affecting a few teams here. I guess another option (but probably harder) would be to investigate what is causing intermittent connectivity issues between CircleCI and static.snyk.io.

[bastiandoetsch]

Please submit that request to CircleCI, as apparently the connection failures occurs even before the request reaches Snyk. We'll be happy to support CircleCI to find a solution with our CDN provider (currently Akamai).

[bastiandoetsch]

Version 1.6.0 of the orb will update the base image and include your fix again. If you want to, you can already test it (#99) with the snyk orb using version dev:develop

[pera]

Thank you @bastiandoetsch, we just tried the dev version and it looks it's working fine now :)

[bastiandoetsch]

That's great, @pera , glad to hear it!