Feat/add snyk code as plugin for test #1664

j-sp4 · 2021-02-26T17:47:37Z

Ready for review
Follows CONTRIBUTING rules
Reviewed by Snyk internal team

What does this PR do?

This introduces an mpv usage for snyk code.

Where should the reviewer start?

you should have the snykcode cli's ff,
and run it with snyk code test or snyk code test <project_path>

How should this be manually tested?

snyk code test or snyk code test <project_path>

Any background context you want to provide?

we will be adding more functionality around this flow, more error handling, analytics, and output functionality, later on

What are the relevant tickets?

https://snyksec.atlassian.net/browse/COD-123

Screenshots

Additional questions

github-actions · 2021-02-26T17:50:08Z

	Warnings
⚠️	Looks like you added a new Tap test. Consider making it a Jest test instead. See files like `test/*.spec.ts` for examples. Files found: `test/fixtures/sast/sample-analyze-folders-response.json` `test/fixtures/sast/sample-sarif.json` `test/fixtures/sast/test-output-windows.txt` `test/fixtures/sast/test-output.txt`

Generated by 🚫 dangerJS against cba65a3

src/lib/errors/unsupported-feature-snyk-code-error.ts

src/lib/plugins/code/index.ts

ArturSnyk · 2021-03-02T13:22:44Z

src/cli/commands/test/index.ts

+      if (error instanceof Error) {
+        throw error;
+      } else {
+        throw new Error(error);


we sometimes throw an Object which is an error(but not as an Error obj), so we would like to wrap it as an actual error

Ideally we should only be throwing Error objects to avoid this inconsistency but that can be fixed outside this PR (ideally with an eslint rule). If error is a non-Error Object, passing it into the Error constructor is odd as that's a message string. But again, that seems to be existing behaviour so not blocking this PR.

aviadhahami

lgtm

darscan · 2021-03-03T12:34:09Z

Please interactively rebase and structure your commit messages so that they make sense as Release Notes - the preview release notes do not make sense right now ( #1664 (comment) )

test/fixtures/code/test-output-windows.txt

.github/CODEOWNERS

src/lib/ecosystems/plugins.ts

src/lib/errors/unsupported-feature-for-org-error.ts

src/lib/plugins/code/analysis.ts

src/lib/plugins/code/format/output-format.ts

src/lib/plugins/code/index.ts

ArturSnyk · 2021-03-03T15:36:33Z

Please interactively rebase and structure your commit messages so that they make sense as Release Notes - the preview release notes do not make sense right now ( #1664 (comment) )

@darscan i will squash the commits before merging. I've split it so it would be easier to review :)

src/lib/plugins/sast/utils/testEmitter.ts

orkamara

👏 Great job @ArturSnyk and @Spoor2709 !

* we are using code-clint lib to analyze a project and expecting to get a sarif typed response. * creating new formating schema for snyk code scanning * adding `snyk code` functionality as an internal plugin * adding `snyk code` behind FF * adding support for the currect exit code (1) when there are vulnerabilities. * we currently have circular import issue. to temporary solve it in our case, we will dynamicly import a module.

github-actions · 2021-03-04T15:30:14Z

Expected release notes (by @ArturSnyk)

features:
add snyk code support, as plugin, for test flow (cba65a3)

I hereby acknowledge these release notes are 🥙 AWESOME 🥙

This reverts commit 3262519, reversing changes made to e1f00ca.

Revert "Merge pull request #1664 from snyk/feat/add-snyk-code-as-plugin-for-test"

j-sp4 force-pushed the feat/add-snyk-code-as-plugin-for-test branch from 097247c to 5f26a44 Compare February 26, 2021 17:50

ArturSnyk force-pushed the feat/add-snyk-code-as-plugin-for-test branch from 8deacf5 to a9fbf6e Compare March 1, 2021 07:33

ArturSnyk reviewed Mar 1, 2021

View reviewed changes

src/lib/errors/unsupported-feature-snyk-code-error.ts Outdated Show resolved Hide resolved

ArturSnyk reviewed Mar 1, 2021

View reviewed changes

src/lib/plugins/code/index.ts Outdated Show resolved Hide resolved

ArturSnyk force-pushed the feat/add-snyk-code-as-plugin-for-test branch 9 times, most recently from eb558d5 to df57e31 Compare March 2, 2021 09:03

ArturSnyk self-assigned this Mar 2, 2021

ArturSnyk mentioned this pull request Mar 2, 2021

Feat/add snyk code test support #1640

Closed

3 tasks

ArturSnyk force-pushed the feat/add-snyk-code-as-plugin-for-test branch 5 times, most recently from 50065dc to 3e42519 Compare March 2, 2021 12:57

ArturSnyk mentioned this pull request Mar 2, 2021

poc: add snykcode to the cli #1604

Closed

3 tasks

ArturSnyk reviewed Mar 2, 2021

View reviewed changes

ArturSnyk marked this pull request as ready for review March 2, 2021 13:25

ArturSnyk requested review from a team as code owners March 2, 2021 13:25

ArturSnyk requested a review from darscan March 3, 2021 11:24

aviadhahami approved these changes Mar 3, 2021

View reviewed changes

darscan reviewed Mar 3, 2021

View reviewed changes

test/fixtures/code/test-output-windows.txt Outdated Show resolved Hide resolved

orkamara reviewed Mar 3, 2021

View reviewed changes

orkamara approved these changes Mar 4, 2021

View reviewed changes

src/lib/plugins/sast/utils/testEmitter.ts Outdated Show resolved Hide resolved

orkamara approved these changes Mar 4, 2021

View reviewed changes

ArturSnyk force-pushed the feat/add-snyk-code-as-plugin-for-test branch 5 times, most recently from 1455c59 to 4169a74 Compare March 4, 2021 11:19

ArturSnyk force-pushed the feat/add-snyk-code-as-plugin-for-test branch from 4169a74 to cba65a3 Compare March 4, 2021 11:20

ArturSnyk merged commit 3262519 into master Mar 4, 2021

ArturSnyk deleted the feat/add-snyk-code-as-plugin-for-test branch March 4, 2021 15:30

github-actions bot mentioned this pull request Mar 4, 2021

Revert "Merge pull request #1664 from snyk/feat/add-snyk-code-as-plugin-for-test" #1682

Merged

JackuB added a commit that referenced this pull request Mar 4, 2021

fix: Revert PR #1664

62bc709

This reverts commit 3262519, reversing changes made to e1f00ca.

JackuB added a commit that referenced this pull request Mar 4, 2021

Merge pull request #1682 from snyk/revert/snyk-code

b01ab95

Revert "Merge pull request #1664 from snyk/feat/add-snyk-code-as-plugin-for-test"

This was referenced Mar 26, 2021

[Snyk] Upgrade snyk from 1.467.0 to 1.471.0 SalesforceCommerceCloud/commerce-sdk#318

Merged

[Snyk] Upgrade snyk from 1.471.0 to 1.477.0 SalesforceCommerceCloud/commerce-sdk#319

Merged

snykerjames mentioned this pull request Nov 13, 2024

[Snyk] Fix for 1 vulnerabilities snykerjames-projects/vuln-app#15

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/add snyk code as plugin for test #1664

Feat/add snyk code as plugin for test #1664

j-sp4 commented Feb 26, 2021 •

edited by ArturSnyk

Loading

github-actions bot commented Feb 26, 2021 •

edited

Loading

ArturSnyk Mar 2, 2021 •

edited

Loading

ghost Mar 2, 2021

aviadhahami left a comment

darscan commented Mar 3, 2021 •

edited

Loading

ArturSnyk commented Mar 3, 2021

orkamara left a comment

github-actions bot commented Mar 4, 2021 •

edited by ArturSnyk

Loading

Feat/add snyk code as plugin for test #1664

Feat/add snyk code as plugin for test #1664

Conversation

j-sp4 commented Feb 26, 2021 • edited by ArturSnyk Loading

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

github-actions bot commented Feb 26, 2021 • edited Loading

ArturSnyk Mar 2, 2021 • edited Loading

Choose a reason for hiding this comment

ghost Mar 2, 2021

Choose a reason for hiding this comment

aviadhahami left a comment

Choose a reason for hiding this comment

darscan commented Mar 3, 2021 • edited Loading

ArturSnyk commented Mar 3, 2021

orkamara left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 4, 2021 • edited by ArturSnyk Loading

j-sp4 commented Feb 26, 2021 •

edited by ArturSnyk

Loading

github-actions bot commented Feb 26, 2021 •

edited

Loading

ArturSnyk Mar 2, 2021 •

edited

Loading

darscan commented Mar 3, 2021 •

edited

Loading

github-actions bot commented Mar 4, 2021 •

edited by ArturSnyk

Loading