Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #1664 from snyk/feat/add-snyk-code-as-plugin-for-test" #1682

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Revert "Merge pull request #1664 from snyk/feat/add-snyk-code-as-plugin-for-test" #1682

merged 1 commit into from
Mar 4, 2021

Conversation

JackuB
Copy link
Contributor

@JackuB JackuB commented Mar 4, 2021

Latest version causes CLI executables to fail.

@JackuB JackuB requested review from a team as code owners March 4, 2021 16:26
@JackuB JackuB requested a review from j-sp4 March 4, 2021 16:26
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021 •
edited
Loading

Warnings
⚠️ You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 62bc709

@JackuB JackuB force-pushed the revert/snyk-code branch from 4d20772 to 6f735eb Compare March 4, 2021 16:29
@JackuB
fix: Revert PR #1664
62bc709 
This reverts commit 3262519, reversing
changes made to e1f00ca.
@JackuB JackuB force-pushed the revert/snyk-code branch from 6f735eb to 62bc709 Compare March 4, 2021 16:59
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021

Expected release notes (by @JackuB)

fixes:
Revert PR #1664 (62bc709)

others (will not be included in Semantic-Release notes):
initial snyk-fix package setup & loadPlugin functionality (a6b708e)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@JackuB JackuB merged commit b01ab95 into master Mar 4, 2021
@JackuB JackuB deleted the revert/snyk-code branch March 4, 2021 17:42
@ArturSnyk ArturSnyk mentioned this pull request Mar 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturSnyk ArturSnyk ArturSnyk approved these changes

@Avishagp Avishagp Avishagp approved these changes

@j-sp4 j-sp4 Awaiting requested review from j-sp4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackuB @ArturSnyk @Avishagp