fix: re-add snyk code support, fixing cli executables #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ArturSnyk
force-pushed
the
revert-1682-revert/snyk-code
branch
from
0cbb543 to
223f364
Compare
ArturSnyk
changed the title
ArturSnyk
force-pushed
the
revert-1682-revert/snyk-code
branch
from
223f364 to
0d918a4
Compare
ArturSnyk
force-pushed
the
revert-1682-revert/snyk-code
branch
from
0d918a4 to
7881dbc
Compare
|
Expected release notes (by @ArturSnyk) fixes: others (will not be included in Semantic-Release notes):
|
1 task
ArturSnyk
commented
Mar 7, 2021
| @@ -2,5 +2,6 @@ | |||
| "API": "https://snyk.io/api/v1", | |||
| "devDeps": false, | |||
| "PRUNE_DEPS_THRESHOLD": 40000, | |||
| "MAX_PATH_COUNT": 1500000 | |||
| "MAX_PATH_COUNT": 1500000, | |||
| "CODE_CLIENT_PROXY_URL": "https://deeproxy.snyk.io" | |||
aviadhahami
approved these changes
Mar 7, 2021
| @@ -2,5 +2,6 @@ | |||
| "API": "https://snyk.io/api/v1", | |||
| "devDeps": false, | |||
| "PRUNE_DEPS_THRESHOLD": 40000, | |||
| "MAX_PATH_COUNT": 1500000 | |||
| "MAX_PATH_COUNT": 1500000, | |||
| "CODE_CLIENT_PROXY_URL": "https://deeproxy.snyk.io" | |||
There was a problem hiding this comment.
Awaiting our Slack discussion :)
There was a problem hiding this comment.
This was referenced Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1682
COD-123
What does this PR do?
This introduces an mpv usage for snyk code.
This is a second attempt:
the first pr failed due to es module issues in flatted from code-client->flat-cache->flatted
This issue has been resolved in code client and we now have a custom implementation of flat-cache specifically for our needs.
A second issue the arose dcignore was not included into executable at compilation stage. dcignore was the deepcode ignore package that is leveraged in the vscode extension through the code-client. However its future is uncertain, I have now raised a discussion around its future that will be decided on in the next week, the most likely outcome will be removing it from the code-client and re-writing the package and only using it through vs-code extension and if needed in the cli using it also directly in the cli.
I have temporarily fixed this by adding it to the included assets of pkg seen on the change in package json.
Where should the reviewer start?
you should have the snykcode cli's ff,
and run it with
snyk code testorsnyk code test <project_path>How should this be manually tested?
snyk code testorsnyk code test <project_path>Any background context you want to provide?
we will be adding more functionality around this flow, more error handling, analytics, and output functionality, later on
What are the relevant tickets?
https://snyksec.atlassian.net/browse/COD-123
Screenshots