Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: content-length header for broker token provision/switch endpoints #340

Closed
wants to merge 1 commit into from
Closed

fix: content-length header for broker token provision/switch endpoints #340

wants to merge 1 commit into from

Conversation

soniqua
Copy link

@soniqua soniqua commented Jul 25, 2024 •
edited
Loading

What

  • Adds Content-Length: 0 to empty POST requests for provision-token and switch-token endpoints

Why

  • Without this (or without --data="") Akamai responds with 411 (no Content-Length header)

@soniqua soniqua marked this pull request as ready for review July 25, 2024 12:42
@soniqua soniqua requested a review from a team as a code owner July 25, 2024 12:42
@gablaxian
Copy link
Contributor

Is this not a breaking change? Or are you updating docs to reflect what was already there?

@gablaxian gablaxian requested a review from a team July 26, 2024 11:12
@soniqua
Copy link
Author

soniqua commented Jul 26, 2024

@gablaxian the latter, this reflects current behaviour

@soniqua soniqua closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soniqua @gablaxian